Skip to content

HBASE-29807 Depend on jcip-annotations explicitly #7592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xavifeds8 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HBASE-29807 Depend on jcip-annotations explicitly #7592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions hbase-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
<dependency>
<groupId>net.jcip</groupId>
<artifactId>jcip-annotations</artifactId>
<scope>compile</scope>
<optional>true</optional>
</dependency>
Comment on lines 84 to 89
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The groupId used here (com.github.stephenc.jcip) is inconsistent with the groupId referenced in supplemental-models.xml (net.jcip). This inconsistency could lead to confusion about which artifact is actually being used. Ensure that the groupId matches what's declared in the root pom.xml's dependencyManagement section, and consider whether both need to align with the existing supplemental-models.xml entry.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@xavifeds8 xavifeds8 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The groupId is moved to net.jcip now.

<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
Expand Down
6 changes: 6 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,6 +952,7 @@
<maven-owasp-plugin.version>12.1.0</maven-owasp-plugin.version>
<os.maven.version>1.7.1</os.maven.version>
<findbugs-annotations.version>1.3.9-1</findbugs-annotations.version>
<jcip-annotations.version>1.0</jcip-annotations.version>
<spotbugs.version>4.7.3</spotbugs.version>
<spotbugs.maven.version>4.7.2.1</spotbugs.maven.version>
<surefire.version>3.5.3</surefire.version>
Expand Down Expand Up @@ -1443,6 +1444,11 @@
<artifactId>findbugs-annotations</artifactId>
<version>${findbugs-annotations.version}</version>
</dependency>
<dependency>
<groupId>net.jcip</groupId>
<artifactId>jcip-annotations</artifactId>
<version>${jcip-annotations.version}</version>
</dependency>
<!--
Logging dependencies. In general, we use slf4j as the log facade in HBase, so all sub
modules should depend on slf4j-api at compile scope, and then depend on log4j-slf4j-impl
Expand Down