HBASE-29807 Depend on jcip-annotations explicitly#7592
Open
xavifeds8 wants to merge 1 commit intoapache:masterfrom
Open
HBASE-29807 Depend on jcip-annotations explicitly#7592xavifeds8 wants to merge 1 commit intoapache:masterfrom
xavifeds8 wants to merge 1 commit intoapache:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
NihalJain
changed the title
NihalJain
reviewed
Jan 6, 2026
pom.xml
Outdated
| <dependency> | ||
| <groupId>com.github.stephenc.jcip</groupId> | ||
| <artifactId>jcip-annotations</artifactId> | ||
| <version>1.0-1</version> |
Contributor
There was a problem hiding this comment.
move it to properties section
There was a problem hiding this comment.
Pull request overview
This PR adds the jcip-annotations dependency to HBase to maintain compatibility with Hadoop 3.4+, where the dependency is no longer transitively provided through nimbus-jose-jwt.
Key Changes:
- Added
jcip-annotationsto the root pom's dependencyManagement section - Added
jcip-annotationsas a compile-scoped optional dependency to hbase-client module
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pom.xml | Adds jcip-annotations to dependencyManagement with version 1.0-1 using groupId com.github.stephenc.jcip |
| hbase-client/pom.xml | Declares jcip-annotations as a compile-scoped optional dependency for the hbase-client module where it's used |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
84
to
89
| <dependency> | ||
| <groupId>com.github.stephenc.jcip</groupId> | ||
| <artifactId>jcip-annotations</artifactId> | ||
| <scope>compile</scope> | ||
| <optional>true</optional> | ||
| </dependency> |
There was a problem hiding this comment.
The groupId used here (com.github.stephenc.jcip) is inconsistent with the groupId referenced in supplemental-models.xml (net.jcip). This inconsistency could lead to confusion about which artifact is actually being used. Ensure that the groupId matches what's declared in the root pom.xml's dependencyManagement section, and consider whether both need to align with the existing supplemental-models.xml entry.
Contributor
Author
There was a problem hiding this comment.
The groupId is moved to net.jcip now.
xavifeds8
changed the title
xavifeds8
force-pushed
the
add_jcip/HBASE-29807
branch
2 times, most recently
from
4aab895 to
c80c665
Compare
xavifeds8
force-pushed
the
add_jcip/HBASE-29807
branch
from
c80c665 to
7d5a9e3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : HBase build fails with latest Hadoop versions due to missing
net.jcip.annotationspackage.Earlier hadoop was dependent on com.nimbusds:nimbus-jose-jwt:jar:9.37.2 (which brought in com.github.stephenc.jcip:jcip-annotations:jar:1.0-1).
With latest hadoop: it has moved to com.nimbusds:nimbus-jose-jwt:jar:10.0.2 (which does not bring in the dependency), refer commit apache/hadoop@3baa288#diff-635a9ebcc70f58d8ca1c55b0d78cc90064a5081d189162a432271778da3cf018.