HBASE-29841: Split bulky ReadOnlyController into multiple smaller controllers #7661
+1,139
−816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trollers Currently we have created a single ReadOnlyController which needs to get added as coprocessor for master, region and region server. In this task we will be breaking ReadOnlyController into multiple smaller controller to avoid unnecessarily adding methods which are not relevant for particular role for example, master copocessor should only register methods which may run on master and not on region or region server.
sharmaar12
force-pushed
the
dyn_cop_reg
branch
from
360a366 to
6e3b3e4
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Jan 23, 2026
Contributor
wchevreuil
left a comment
wchevreuil
left a comment
There was a problem hiding this comment.
LGTM, just have few nits.
| return Optional.of(this); | ||
| } | ||
|
|
||
| /* ---- ConfigurationObserver Overrides ---- */ |
Contributor
There was a problem hiding this comment.
nit: remove this comment and add @Override annotation.
| HConstants.HBASE_GLOBAL_READONLY_ENABLED_KEY, this.globalReadOnlyEnabled); | ||
| } | ||
|
|
||
| /* ---- BulkLoadObserver Overrides ---- */ |
Contributor
There was a problem hiding this comment.
nit: remove this comment.
| return Optional.of(this); | ||
| } | ||
|
|
||
| /* ---- ConfigurationObserver Overrides ---- */ |
Contributor
There was a problem hiding this comment.
nit: remove this comment and add @Override annotation.
| if (!isOnMeta(c)) { | ||
| internalReadOnlyGuard(); | ||
| /* ---- ConfigurationObserver Overrides ---- */ | ||
| public void onConfigurationChange(Configuration conf) { |
Contributor
There was a problem hiding this comment.
nit: remove this comment and add @Override annotation.
| return Optional.of(this); | ||
| } | ||
|
|
||
| /* ---- MasterObserver Overrides ---- */ |
Contributor
There was a problem hiding this comment.
nit: remove this comment.
| } | ||
|
|
||
| /* ---- ConfigurationObserver Overrides ---- */ | ||
| public void onConfigurationChange(Configuration conf) { |
Contributor
There was a problem hiding this comment.
nit: remove this comment and add @Override annotation.
| HConstants.HBASE_GLOBAL_READONLY_ENABLED_KEY, this.globalReadOnlyEnabled); | ||
| } | ||
|
|
||
| /* ---- RegionServerObserver Overrides ---- */ |
Contributor
There was a problem hiding this comment.
nit: remove this comment.
| } | ||
|
|
||
| /* ---- ConfigurationObserver Overrides ---- */ | ||
| public void onConfigurationChange(Configuration conf) { |
Contributor
There was a problem hiding this comment.
nit: remove this comment and add @Override annotation.
| } | ||
| } | ||
|
|
||
| /* ---- RegionObserver Overrides ---- */ |
Contributor
There was a problem hiding this comment.
nit: remove this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have created a single ReadOnlyController which needs to get added as coprocessor for master, region and region server. In this task we will be breaking ReadOnlyController into multiple smaller controller to avoid unnecessarily adding methods which are not relevant for particular role for example, master copocessor should only register methods which may run on master and not on region or region server.