HBASE-30247 Validate negative client timeout configuration#8458
Open
velpro-8620 wants to merge 1 commit into
Open
HBASE-30247 Validate negative client timeout configuration#8458velpro-8620 wants to merge 1 commit into
velpro-8620 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds fail-fast validation for negative client timeout configuration values during ConnectionConfiguration construction in hbase-client, preventing later runtime failures (e.g., during batch operations in AsyncProcess) and improving diagnosability of misconfiguration.
Changes:
- Introduces a helper to reject negative timeout values (throws
IllegalArgumentExceptionwith the offending key/value). - Applies non-negative validation to multiple client timeout-related configuration keys when building
ConnectionConfiguration. - Adds unit tests asserting negative values are rejected and zero values remain allowed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionConfiguration.java | Adds non-negative validation for client timeout configs during connection configuration construction. |
| hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestConnectionConfiguration.java | Adds tests to verify negative timeout values fail fast and zero values are accepted. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+120
to
+121
| this.replicaCallTimeoutMicroSecondScan = getNonNegativeInt(conf, PRIMARY_SCAN_TIMEOUT_MICROSECOND, | ||
| PRIMARY_SCAN_TIMEOUT_MICROSECOND_DEFAULT); |
Comment on lines
+53
to
+58
| List<String> timeoutKeys = Arrays.asList(HConstants.HBASE_CLIENT_META_OPERATION_TIMEOUT, | ||
| HConstants.HBASE_CLIENT_OPERATION_TIMEOUT, ConnectionConfiguration.PRIMARY_CALL_TIMEOUT_MICROSECOND, | ||
| ConnectionConfiguration.PRIMARY_SCAN_TIMEOUT_MICROSECOND, | ||
| HConstants.HBASE_CLIENT_META_REPLICA_SCAN_TIMEOUT, HConstants.HBASE_RPC_TIMEOUT_KEY, | ||
| HConstants.HBASE_RPC_READ_TIMEOUT_KEY, ConnectionConfiguration.HBASE_CLIENT_META_READ_RPC_TIMEOUT_KEY, | ||
| HConstants.HBASE_RPC_WRITE_TIMEOUT_KEY); |
Member
|
Please run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change validates negative client timeout configuration values when constructing
ConnectionConfiguration.Invalid values such as
hbase.rpc.timeout=-1now fail early withIllegalArgumentExceptioninstead of later failing during batchPutinAsyncProcess.Why are the changes needed?
HBASE-30247 reports that a negative
hbase.rpc.timeoutis accepted during clientconfiguration and only fails later at runtime during batch operations.
Failing fast makes the configuration error easier to diagnose and prevents the
surprising runtime exception path.
How was this patch tested?
mvn -pl hbase-client -am -DskipITs -Dtest=TestConnectionConfiguration test