RFC 7639 ALPN - #731
Open
arturobernalg wants to merge 1 commit into
Open
Conversation
arturobernalg
force-pushed
the
rfc7639
branch
2 times, most recently
from
October 15, 2025 17:45
42fd028 to
6140646
Compare
arturobernalg
marked this pull request as ready for review
October 15, 2025 17:45
arturobernalg
force-pushed
the
rfc7639
branch
from
October 15, 2025 18:31
4b95aca to
8f872b6
Compare
arturobernalg
marked this pull request as draft
October 15, 2025 18:33
arturobernalg
force-pushed
the
rfc7639
branch
from
October 15, 2025 18:39
aea3fa3 to
5fa9a19
Compare
arturobernalg
marked this pull request as ready for review
October 15, 2025 18:43
arturobernalg
force-pushed
the
rfc7639
branch
from
October 18, 2025 17:11
5fa9a19 to
16b5442
Compare
Member
|
@arturobernalg Could you please rebase this change-set? |
arturobernalg
force-pushed
the
rfc7639
branch
2 times, most recently
from
December 20, 2025 12:20
cc58cd1 to
208b565
Compare
Member
Author
@ok2c done. |
arturobernalg
force-pushed
the
rfc7639
branch
from
January 11, 2026 09:28
208b565 to
eed86b1
Compare
ok2c
reviewed
Jan 11, 2026
ok2c
reviewed
Jan 11, 2026
ok2c
reviewed
Jan 11, 2026
arturobernalg
force-pushed
the
rfc7639
branch
from
January 11, 2026 18:42
733a98c to
a910585
Compare
ok2c
reviewed
Jan 11, 2026
arturobernalg
force-pushed
the
rfc7639
branch
2 times, most recently
from
January 12, 2026 09:57
a178fe7 to
e343841
Compare
ok2c
reviewed
Jan 12, 2026
arturobernalg
force-pushed
the
rfc7639
branch
2 times, most recently
from
January 12, 2026 15:17
249924c to
bfb72b3
Compare
arturobernalg
force-pushed
the
rfc7639
branch
from
February 6, 2026 07:13
bfb72b3 to
f5f17fd
Compare
ok2c
reviewed
Apr 3, 2026
Member
|
@arturobernalg This change can still make it into |
arturobernalg
force-pushed
the
rfc7639
branch
2 times, most recently
from
June 19, 2026 11:57
36079e1 to
46a533e
Compare
Member
Author
@ok2c please do another pass |
ok2c
reviewed
Jul 4, 2026
arturobernalg
force-pushed
the
rfc7639
branch
2 times, most recently
from
July 11, 2026 18:07
05a370f to
0af7b0f
Compare
ok2c
reviewed
Jul 17, 2026
ok2c
left a comment
ok2c
left a comment
Member
There was a problem hiding this comment.
@arturobernalg Much, much better! However, we need to figure out a better of way of passing the actual TLS policy to the interceptors. I would try to solve it by adding HttpVersionPolicy as an attribute to HttpClientContext
arturobernalg
force-pushed
the
rfc7639
branch
2 times, most recently
from
August 10, 2026 11:53
81027eb to
d16d456
Compare
ok2c
requested changes
Aug 14, 2026
| final SocketConfig socketConfig = resolveSocketConfig(route); | ||
| final ConnectionConfig connectionConfig = resolveConnectionConfig(route); | ||
| final TlsConfig tlsConfig = resolveTlsConfig(route.getTargetHost()); | ||
| HttpClientContext.castOrCreate(context).setHttpVersionPolicy(tlsConfig.getHttpVersionPolicy()); |
Member
There was a problem hiding this comment.
@arturobernalg One last bit. Let's do HttpClientContext#cast here instead and assign the attribute only if the context is non null. There is no point creating a new context here.
| LOG.debug("{} connecting endpoint to {} ({})", ConnPoolSupport.getId(endpoint), firstHop, connectTimeout); | ||
| } | ||
| final TlsConfig targetTlsConfig = resolveTlsConfig(route.getTargetHost()); | ||
| HttpClientContext.castOrCreate(context).setHttpVersionPolicy(targetTlsConfig.getHttpVersionPolicy()); |
ok2c
requested changes
Aug 14, 2026
ok2c
left a comment
ok2c
left a comment
Member
There was a problem hiding this comment.
@arturobernalg Almost there. See my comments
Encode protocol IDs with core's PercentCodec.HTTP_TOKEN (canonical RFC 7230 tchar form, uppercase hex) and decode strictly, rejecting malformed percent-encoding with ProtocolException. The advertised protocol set is derived from the target's HttpVersionPolicy. The connection manager resolves the effective TlsConfig and publishes the policy on HttpClientContext before the connection is established; ConnectExec and AsyncConnectExec read it back and, on secure CONNECT tunnels, advertise the same protocols the tunnel's TLS layer will offer, so the header cannot diverge from the protocol negotiated inside the tunnel. Interceptors fall back to NEGOTIATE when no policy is present on the context.
Member
Author
Please do a
@ok2c Please do another pass. |
ok2c
approved these changes
Aug 14, 2026
ok2c
left a comment
ok2c
left a comment
Member
There was a problem hiding this comment.
@arturobernalg Please add RFC 7639 to the list of supported RFCs in README.md and feel free to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ConnectAlpnProvider and inject ALPN header in ConnectExec/AsyncConnectExec. Provide builder hooks for fixed list or provider-driven values.