Verify the server authentication (rspauth) provided in the Digest Authentication-Info response per RFC 7616 - #872
Open
arturobernalg wants to merge 1 commit into
Open
Conversation
arturobernalg
marked this pull request as ready for review
August 14, 2026 10:28
michael-o
reviewed
Aug 14, 2026
arturobernalg
force-pushed
the
digest-rspauth
branch
2 times, most recently
from
August 14, 2026 10:59
324a033 to
309aff3
Compare
michael-o
approved these changes
Aug 14, 2026
michael-o
left a comment
michael-o
left a comment
Member
There was a problem hiding this comment.
I have no formal objection, but cannot reasonable judge on the actual code.
ok2c
approved these changes
Aug 14, 2026
ok2c
left a comment
ok2c
left a comment
Member
There was a problem hiding this comment.
@arturobernalg Likewise, I could not spot anything objectionable code-wise, but cannot comment as far as RFC 7616 conformance is concerned. I trust you know what you are doing.
…hentication-Info response per RFC 7616 The client recomputes rspauth from the session state of the last request and compares it to the value returned by the server in constant time, so mutual authentication no longer depends solely on the request being accepted. For qop=auth the cnonce and nc echoed by the server are required and must match the values used for that request, and an Authentication-Info that states qop=auth must carry rspauth, cnonce and nc. Verification is confined to qop=auth; the rspauth of qop=auth-int hashes the response body, which is not available to the scheme. An Authentication-Info without rspauth remains acceptable unless the server states qop=auth. Authentication-Info is a list field that a server may split across multiple field lines; AuthenticationHandler now combines the parameters from all of them into a single challenge so the scheme sees the complete set rather than only the last line.
arturobernalg
force-pushed
the
digest-rspauth
branch
from
August 15, 2026 06:12
309aff3 to
6f53acf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client recomputes
rspauthfrom the session state of the last request and compares it to the value returned by the server in constant time, so mutual authentication no longer depends solely on the request being accepted. Forqop=auththecnonceandncechoed by the server are required and must match the values used for that request, and an Authentication-Info that statesqop=authmust carryrspauth,cnonceandnc. Verification is confined toqop=auth;therspauthofqop=auth-inthashes the response body, which is not available to the scheme. An Authentication-Info withoutrspauthremains acceptable unless the server statesqop=auth.