Add RFC 7639 canonical percent codec for ALPN protocol identifiers. #596
Conversation
ok2c
left a comment
ok2c
left a comment
There was a problem hiding this comment.
and guarantees uppercase hex
@arturobernalg I do not see any changes in the behavior of the codec to that effect but so be it.
|
|
||
| private final BitSet unreserved; | ||
|
|
||
| private PercentCodec(final BitSet unreserved) { |
There was a problem hiding this comment.
@arturobernalg Let's make the constructor public and mark it @Internal
There was a problem hiding this comment.
@arturobernalg Let's make the constructor public and mark it
@Internal
Done
|
@arturobernalg Could there be a better name than |
arturobernalg
force-pushed
the
rfc7639-percentcodec
branch
from
6d8c5f6 to
61f0389
Compare
Done . @ok2c please let me know if then name now its more significant |
|
|
||
| public static final PercentCodec RFC3986 = new PercentCodec(UNRESERVED); | ||
| public static final PercentCodec RFC5987 = new PercentCodec(RFC5987_UNRESERVED); | ||
| public static final PercentCodec RFC7230_TOKEN = new PercentCodec(RFC7639_UNRESERVED); |
There was a problem hiding this comment.
@arturobernalg Could we also rename RFC7639_UNRESERVED the same way?
RFC7230 has already been superseded by RFC911x. Would not HTTP_TOKEN be better?
Preserve token tchar octets (except '%') and enforce uppercase hex.
arturobernalg
force-pushed
the
rfc7639-percentcodec
branch
from
8392102 to
7af06d6
Compare
2 participants
Introduce PercentCodec.RFC7639 for canonical ALPN protocol-id encoding per RFC 7639.