Skip to content

CMake: update minimum version required#640

Closed
jmckenna wants to merge 18 commits intoapache:trunkfrom
jmckenna:cmake-min-required
Closed

CMake: update minimum version required#640
jmckenna wants to merge 18 commits intoapache:trunkfrom
jmckenna:cmake-min-required

Conversation

@jmckenna
Copy link
Copy Markdown

  • to avoid the following fatal error with CMake 4.3.2:
CMake Error at CMakeLists.txt:20 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

covener and others added 18 commits April 26, 2026 15:47
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1933351 13f79535-47bb-0310-9956-ffa450edef68
* include/httpd.h: Declare ap_memeq_timingsafe(),
  ap_streq_timingsafe(), ap_strneq_timingsafe().

* server/util.c: Implement, wrapping apr_*_timingsafe() if
  APR >= 1.8, with a fallback to copied-in versions.

* modules/aaa/mod_auth_digest.c: Replace apr_crypto_equals()
  with ap_memeq_timingsafe(). Remove apr_crypto.h include.

* modules/session/mod_session_crypto.c: Replace local
  ap_crypto_equals() with ap_memeq_timingsafe(). Remove
  the local implementation and macro alias.

Github: closes apache#638


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1933389 13f79535-47bb-0310-9956-ffa450edef68
@notroj
Copy link
Copy Markdown
Collaborator

notroj commented May 7, 2026

Thanks for the PR!

@notroj
Copy link
Copy Markdown
Collaborator

notroj commented May 7, 2026

Not sure if you're using this to build on Linux or Windows but still seeing build failures in CI on Windows after this https://github.com/apache/httpd/actions/runs/25502886791/job/74840430128#step:5:1097

@jmckenna
Copy link
Copy Markdown
Author

jmckenna commented May 7, 2026

@notroj I build on Windows with Visual Studio - odd, I'll have a look (I compile in CMake with CMAKE_BUILD_TYPE=RelWithDebInfo, but I see that your action uses CMAKE_BUILD_TYPE=Debug, I'll try a build with that locally too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants