Fix ACME RewriteRule pattern in .htaccess recipe - #686
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the mod_rewrite documentation to correct an .htaccess example so ACME HTTP-01 challenge requests are properly exempted from an HTTP→HTTPS redirect in per-directory (.htaccess) context.
Changes:
- Fix the ACME exemption
RewriteRulepattern by removing the leading/, aligning it with.htaccess(per-dir) path matching behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@deprrous appreciate all your contributions - since we have to merge these into SVN and these are all really small changes, could you stick them into a smaller number of PRs? They would be much easier to review/merge in one go. |
|
The rewrite directive in the actual doc is correct. |
The ACME exemption example is chained from the
.htaccessHTTPS redirect recipe in this file.In per-directory context,
RewriteRulematches the path without a leading slash, so^/\.well-known/acme-challenge/does not match ordinary ACME challenge requests there. Dropping the leading slash makes the exemption line up with the.htaccesscontext described above it.