mod_speling: avoid out-of-bounds read in check_speling - #778
Open
arshsmith1 wants to merge 1 commit into
Open
arshsmith1 wants to merge 1 commit into
arshsmith1 wants to merge 1 commit into
Conversation
Collaborator
|
Thanks. Any chance of a test case as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_speling() assumes postgood (the mapped file base name plus any PATH_INFO) is a trailing substring of r->uri, but nothing enforces that before it computes r->uri + (urlen - pglen) for the suffix compare. When a mapper such as Alias or a RewriteRule points a short URI at a nonexistent file whose base name is longer, pglen exceeds urlen, the int subtraction goes negative, and the strcmp reads before the start of the r->uri buffer (the apr_pstrndup that follows also gets a negative length). Returning DECLINED when pglen > urlen keeps the compare in bounds and leaves the normal suffix case unchanged.
AI tooling was used to help prepare this change.