Repository navigation
Conversation
- document bilingual ownership and Java/SPI changes - describe coordinated upgrades and legacy data limits - align dependency inventory prerequisites and links
- Lead both languages with affected integrations and Java examples - Explain ownership and upgrade steps with generated illustrations - Keep compatibility limits in readable reference tables
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The guide's API and SPI claims match apache/hugegraph#3270, but its import table maps two whole packages to struct when some of their classes stay in core, so readers who apply those rows as written get imports that do not compile. Score 7/10. Evidence: static review of exact head 611003d against #3270 head eee539d49d67 (class locations via git ls-tree, HugeGraph.sameAs, GraphSerializer.writeIndex/readIndex, HugeElement.element()/wrapProperty, BaseVertex.TypeContext, pd.cluster default hg, Server cluster/usePD and graph pd.cluster options, regenerate_known_dependencies.sh and dependency_inventory.py); all latest-head checks pass.
imbajin
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The migration guide omits the Server-wide PD namespace binding and the inventory command can retain stale jars on a reused checkout. Evidence: Paired implementation and inventory-collector locations are linked in the inline comments.
- record the merged Server implementation in both languages - link the current source migration guide and retain upgrade limits - synchronize build prerequisites and CI-friendly POM guidance
- identify relocated types and preserve core helper imports - clarify the shared Server metadata namespace and ignored conflicts - clean packaged dependency directories before inventory collection
95b52cf to
2104942
Compare
imbajin
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The documented root Maven clean command can remove the PD and Store source trees through their distribution modules' broad Clean filesets. Evidence: the merged Server #3270 POMs point dist.dir at each parent module directory and configure it as a fileset; Maven Clean selects all paths when includes is empty, as linked in the inline comment.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The guide's class locations, SPI signatures, PD namespace rules and build prerequisites match merged apache/hugegraph#3270 (master 5039e5b67), and the earlier findings on the ID/query rows and the Server-wide namespace binding are fixed at this head. The root mvn clean install in the inventory step is safe: I ran mvn clean from the root of a throwaway master worktree, and it removed only the versioned distribution directories and tarballs and left every tracked file in place. One minor gap remains: the schema row doesn't say that SchemaManager stays in core. Evidence: read the full exact-head diff (EN and CN); used git ls-files on apache/hugegraph master to check every relocated and retained class in the mapping table; checked HugeGraph.sameAs(HugeGraphSupplier), GraphSerializer.writeIndex/readIndex(Index), HugeElement.element()/wrapProperty, BaseVertex.TypeContext, the Store @Value("${pd.cluster:hg}"), the StandardHugeGraph MetaManager binding and warning, the root POM (maven.compiler.release 17, requireMavenVersion [3.6.3,), flatten in process-resources) and the dependency_inventory.py distribution paths. mvn -o clean from the root, run with stale apache-hugegraph-{server,pd,store}-1.8.0/lib jars present, removed those directories and left git status empty: the effective PD/Store Clean filesets inherit the includes *.tar, *.tar.gz, .flattened-pom.xml and ${final.name}/** from the parent POMs. Latest-head prepare check passes.
- Scope clean guidance to actual distribution outputs - Mention removal of root distribution archives - Document the shared query serializer package
- Keep SchemaManager in the core schema package - Align English and Chinese migration guidance - Distinguish engine entry points from shared metadata
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: At 13ecb59 the guide's class mappings (including the new backend.query.serializer row and the SchemaManager note), SPI signatures, PD namespace rules and build prerequisites match apache/hugegraph master 36bc1c64b, and the English and Chinese pages agree. One minor inaccuracy is new in this head: the sentence about which *.tar.gz files clean removes names the repository root, but the wildcard applies to the three module directories. Evidence: read the full exact-head diff (EN and CN) and the 2104942..13ecb59 delta; used git ls-tree on master 36bc1c64b and the 1.7.0 tag to check every moved and retained class in the mapping table, HugeGraph.sameAs(HugeGraphSupplier), GraphSerializer.writeIndex/readIndex with Index, HugeElement.element()/wrapProperty, BaseVertex.TypeContext, Store @Value("${pd.cluster:hg}"), the StandardHugeGraph namespace warning, optional jjwt in hugegraph-common, the root POM (maven.compiler.release 17, requireMavenVersion [3.6.3,), flatten in process-resources) and the install-dist paths; ran mvn -o clean from the root of a throwaway master worktree with marker archives and directories, which left git status clean for tracked files; link targets, images and version_routes.json entries exist at the head, git diff --check is clean and all latest-head checks pass.
中文说明 (Chinese Summary)
背景与目标
在 HugeGraph 1.8.0 中,底层对 Core 和 Struct 重复代码进行了重构与下沉(Shared Foundation),合并为 Core 与 Store 共同依赖的统一基础模块。为解决旧文档插件 API 与包名停留在 1.7.0 的问题,本 PR 新增 1.8.0 基础模块迁移指南,并同步更新插件开发与贡献者构建指引。
主要改动
shared-foundation-migration.md):IdGenerator等核心类为例,清晰列出新旧 package import 对照表与 API/SPI 调整。custom-plugin.md,contribute.md):version_routes.json, 图片静态资源):边界与注意事项
English Description
Summary
Add a comprehensive bilingual guide for the 1.8.0 Shared-Foundation Migration (consolidating duplicated Core and Struct components into unified shared modules), and update plugin development and contributor build instructions.
Key Changes
shared-foundation-migration.md):IdGenerator) and API/SPI comparison tables for custom extensions.custom-plugin.md,contribute.md):Scope & Boundaries
Related Implementation PRs
Verification
dist/validate-links.sh)Architectural Overview