Skip to content

chore: align review rules for code and Markdown - #3274

Closed
imbajin wants to merge 6 commits into
apache:masterfrom
hugegraph:task/review-formatting-20261005
Closed

imbajin wants to merge 6 commits into
apache:masterfrom
hugegraph:task/review-formatting-20261005

Conversation

@imbajin

@imbajin imbajin commented Oct 6, 2026

Copy link
Copy Markdown
Member

Purpose of the PR

Align automated review guidance with the repository's 120-column code style. Markdown can keep complete paragraphs or wrap near 160 columns, preserving links, tables and code blocks.

Main Changes

Add review rules covering normal and hidden paths, and document the same policy in the contribution guide. This changes review guidance, not production code. The branch is shared with fork PR #268; future updates stay synchronized.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)

YAML structure, tracked-path coverage including hidden files, and documentation links checked. The upstream diff contains only the two policy files; fork-only CI helpers are excluded.

Does this PR potentially affect the following parts?

  • Dependencies
  • Modify configurations
  • The public API
  • Other affects
  • Nope

Documentation Status

  • Doc - TODO
  • Doc - Done: docs/CONTRIBUTING.md
  • Doc - No Need

- Keep the newest run for each workflow and PR
- Verify source freshness before automatic retries
- Test retry decisions and document the CI policy
- keep ordinary code at 120 columns
- allow Markdown paragraphs or 160 columns
- align CodeRabbit with repository formatting
- document source formatting separately
- replace extension allowlists with general paths
- include current dotfiles and hidden directories
- preserve Markdown and language exceptions
- verify coverage against the tracked file inventory
- incorporate the current Java 17 baseline
- retain the scoped PR changes
- preserve branch history without rewriting commits
- restore upstream CI content for focused review
- remove fork-only rerun helper artifacts
- retain existing branch names and commit history
@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.74%. Comparing base (8fd9841) to head (3900381).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3274      +/-   ##
============================================
- Coverage     41.69%   36.74%   -4.95%     
+ Complexity     7365     4649    -2716     
============================================
  Files           794      537     -257     
  Lines         69291    50827   -18464     
  Branches       9288     7212    -2076     
============================================
- Hits          28891    18677   -10214     
+ Misses        37113    29838    -7275     
+ Partials       3287     2312     -975     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@imbajin

imbajin commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

Closing this separate formatting/configuration PR in favor of the existing repository rules. The core work continues in #3275.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant