feat(rest): implement load table and drop table #438
+232
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gty404
reviewed
Dec 26, 2025
| /// ErrorKind::kNoSuchNamespace if the namespace does not exist; | ||
| /// ErrorKind::kNotAllowed if the namespace is not empty | ||
| virtual Status DropNamespace(const Namespace& ns) = 0; | ||
| virtual Result<bool> DropNamespace(const Namespace& ns) = 0; |
Contributor
There was a problem hiding this comment.
For the scenarios where the namespace does not exist or is not empty, return "NoSuchNamespace/NamespaceNotEmpty" and unify the return with Status. I think it is more suitable for the caller to handle it, and the Status can also include the specific namespace name. In scenarios with multiple nested calls, the outermost layer can more easily identify the root cause.
wgtmac
reviewed
Dec 26, 2025
| { | ||
| std::lock_guard guard(session_mutex_); | ||
| PrepareSession(path, headers); | ||
| PrepareSession(path, headers, params); |
Member
There was a problem hiding this comment.
Let's reorder params and headers for PrepareSession as well?
wgtmac
reviewed
Dec 26, 2025
| auto check = CheckEndpoint(supported_endpoints_, Endpoint::TableExists()); | ||
| if (!check.has_value()) { | ||
| // Fall back to LoadTable endpoint (GET) | ||
| ICEBERG_ASSIGN_OR_RAISE(auto path, paths_->Table(identifier)); |
Member
There was a problem hiding this comment.
Please reuse LoadTable instead of calling the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #392 .
close #396 .
close #394 .