Skip to content
Open
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
665b970
feat!: Support compression codecs for JSON metadata and Avro
emkornfield Nov 12, 2025
091d3bc
fmt
emkornfield Nov 13, 2025
41a8c1c
fix clippy
emkornfield Nov 13, 2025
51e781e
clippy again
emkornfield Nov 13, 2025
253bf59
wip
emkornfield Nov 16, 2025
8bdb52d
address comments
emkornfield Nov 16, 2025
9d27116
no clone needed
emkornfield Nov 16, 2025
d1ee0b2
test compression works
emkornfield Nov 16, 2025
393622f
comments
emkornfield Nov 17, 2025
46fdb8e
update tests
emkornfield Nov 17, 2025
d50cb7d
address comments
emkornfield Nov 19, 2025
5370f77
remove parse optional property
emkornfield Nov 19, 2025
6b3d8ed
fmt
emkornfield Nov 19, 2025
5ec090f
wip
emkornfield Nov 21, 2025
4337a34
address comments
emkornfield Nov 21, 2025
dba26a1
put parsing in table properties
emkornfield Dec 11, 2025
d81ba56
cargo fmt
emkornfield Dec 16, 2025
23384ab
fmt
emkornfield Dec 16, 2025
173fbef
remove unneeded tests
emkornfield Dec 16, 2025
a52d015
fix package import
emkornfield Dec 16, 2025
f4dd663
clippy and visibility
emkornfield Dec 16, 2025
6745adf
merge main
emkornfield Dec 16, 2025
95a217e
fix
emkornfield Dec 16, 2025
ef41b4d
update cargo lock
emkornfield Dec 16, 2025
d9603ff
add missing args
emkornfield Dec 16, 2025
e43e0cc
address clippy
emkornfield Dec 16, 2025
0ec5784
Fmt
emkornfield Dec 16, 2025
ed71f0e
move use statements to top level
emkornfield Dec 16, 2025
edb6886
remove duplicate imports
emkornfield Dec 16, 2025
9d361e1
Merge databricks/main into fix_compression
emkornfield Jan 5, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ rust-version = "1.87"

[workspace.dependencies]
anyhow = "1.0.72"
apache-avro = { version = "0.20", features = ["zstandard"] }
apache-avro = { version = "0.20", features = ["zstandard", "snappy"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enable the ability for avro to read/write snappy compressed files.

array-init = "2"
arrow-arith = "56.2"
arrow-array = "56.2"
Expand Down
2 changes: 2 additions & 0 deletions crates/iceberg/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ flate2 = { workspace = true }
fnv = { workspace = true }
futures = { workspace = true }
itertools = { workspace = true }
log = { workspace = true }
miniz_oxide = "0.8"
moka = { version = "0.12.10", features = ["future"] }
murmur3 = { workspace = true }
num-bigint = { workspace = true }
Expand Down
7 changes: 5 additions & 2 deletions crates/iceberg/src/io/object_cache.rs
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,9 @@ mod tests {
use crate::TableIdent;
use crate::io::{FileIO, OutputFile};
use crate::spec::{
DataContentType, DataFileBuilder, DataFileFormat, Literal, ManifestEntry,
ManifestListWriter, ManifestStatus, ManifestWriterBuilder, Struct, TableMetadata,
CompressionSettings, DataContentType, DataFileBuilder, DataFileFormat, Literal,
ManifestEntry, ManifestListWriter, ManifestStatus, ManifestWriterBuilder, Struct,
TableMetadata,
};
use crate::table::Table;

Expand Down Expand Up @@ -275,6 +276,7 @@ mod tests {
None,
current_schema.clone(),
current_partition_spec.as_ref().clone(),
CompressionSettings::default(),
)
.build_v2_data();
writer
Expand Down Expand Up @@ -307,6 +309,7 @@ mod tests {
current_snapshot.snapshot_id(),
current_snapshot.parent_snapshot_id(),
current_snapshot.sequence_number(),
CompressionSettings::default(),
);
manifest_list_write
.add_manifests(vec![data_file_manifest].into_iter())
Expand Down
10 changes: 7 additions & 3 deletions crates/iceberg/src/scan/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -577,9 +577,9 @@ pub mod tests {
use crate::io::{FileIO, OutputFile};
use crate::scan::FileScanTask;
use crate::spec::{
DataContentType, DataFileBuilder, DataFileFormat, Datum, Literal, ManifestEntry,
ManifestListWriter, ManifestStatus, ManifestWriterBuilder, NestedField, PartitionSpec,
PrimitiveType, Schema, Struct, StructType, TableMetadata, Type,
CompressionSettings, DataContentType, DataFileBuilder, DataFileFormat, Datum, Literal,
ManifestEntry, ManifestListWriter, ManifestStatus, ManifestWriterBuilder, NestedField,
PartitionSpec, PrimitiveType, Schema, Struct, StructType, TableMetadata, Type,
};
use crate::table::Table;

Expand Down Expand Up @@ -749,6 +749,7 @@ pub mod tests {
None,
current_schema.clone(),
current_partition_spec.as_ref().clone(),
CompressionSettings::default(),
)
.build_v2_data();
writer
Expand Down Expand Up @@ -826,6 +827,7 @@ pub mod tests {
current_snapshot.snapshot_id(),
current_snapshot.parent_snapshot_id(),
current_snapshot.sequence_number(),
CompressionSettings::default(),
);
manifest_list_write
.add_manifests(vec![data_file_manifest].into_iter())
Expand Down Expand Up @@ -961,6 +963,7 @@ pub mod tests {
None,
current_schema.clone(),
current_partition_spec.as_ref().clone(),
CompressionSettings::default(),
)
.build_v2_data();

Expand Down Expand Up @@ -1045,6 +1048,7 @@ pub mod tests {
current_snapshot.snapshot_id(),
current_snapshot.parent_snapshot_id(),
current_snapshot.sequence_number(),
CompressionSettings::default(),
);
manifest_list_write
.add_manifests(vec![data_file_manifest].into_iter())
Expand Down
Loading
Loading