Fix IoTConsensus reconstruction IT follower synchronization - #18536
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18536 +/- ##
============================================
- Coverage 42.24% 42.06% -0.18%
Complexity 413 413
============================================
Files 5409 5409
Lines 389925 389925
Branches 50970 50970
============================================
- Hits 164721 164035 -686
- Misses 225204 225890 +686 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CRZbulabula
force-pushed
the
yongzao/fix-iotv1-follower-sync
branch
from
August 27, 2026 12:26
c885b54 to
697b7d4
Compare
CRZbulabula
force-pushed
the
yongzao/fix-iotv1-follower-sync
branch
from
August 27, 2026 15:34
697b7d4 to
b7976d3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Motivation
Ensure the IoTConsensus reconstruction IT waits until the follower has received the inserted data before deleting its TsFiles and exercising the reconstruction failure path. The follower is queried through a DataNode-pinned connection, and the tree-model timestamp column is accounted for when validating the two value columns.
Replace the unbounded
while (true)polling loops with bounded Awaitility assertions (one-second polling and a one-minute timeout), assert that TsFile deletion succeeds, close temporary query result handles, and retain the reconstruction status check with its ten-minute bound.Verification
mvn spotless:apply -P with-integration-tests -pl integration-testmvn verify -DskipUTs -Dit.test=IoTDBRegionReconstructForIoTV1IT#normal1C3DTest -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false -pl integration-test -am -PClusterIT -P with-integration-testsThe targeted IT passed with 1 test, 0 failures, and 0 errors.