KAFKA-20366: Add syntax highlighting across docs (security and streams)#21965
Open
gomudayya wants to merge 3 commits intoapache:trunkfrom
Open
KAFKA-20366: Add syntax highlighting across docs (security and streams)#21965gomudayya wants to merge 3 commits intoapache:trunkfrom
gomudayya wants to merge 3 commits intoapache:trunkfrom
Conversation
mimaison
reviewed
Apr 10, 2026
Member
mimaison
left a comment
mimaison
left a comment
There was a problem hiding this comment.
Thanks for the PR. I left a couple of comments
| 1. Add a JAAS config file with a client login section named `KafkaClient`. Configure a login module in `KafkaClient` for the selected mechanism as described in the examples for setting up GSSAPI (Kerberos), PLAIN, SCRAM, or non-production/production OAUTHBEARER. For example, GSSAPI credentials may be configured as: | ||
|
|
||
| ``` | ||
| ```text |
Member
There was a problem hiding this comment.
Is there any value in setting the language to test?
| user_admin="admin-secret" \ | ||
| user_alice="alice-secret"; | ||
|
|
||
| ```properties |
Member
There was a problem hiding this comment.
Is properties the correct language? According to https://gohugo.io/content-management/syntax-highlighting/#languages I see it called java-properties
Member
|
I'd recommend doing it one folder at a time. It does not make a lot of sense to do Streams and Security in the same PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.