Fix #266: Remove duplicate redirect causing JSON unmarshal error on n…#378
Open
Kaustubh1204 wants to merge 1 commit intoapache:unstablefrom
Open
Fix #266: Remove duplicate redirect causing JSON unmarshal error on n…#378Kaustubh1204 wants to merge 1 commit intoapache:unstablefrom
Kaustubh1204 wants to merge 1 commit intoapache:unstablefrom
Conversation
…r on non-loopback IPs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #266:
kvctlcommands fail with "unexpected end of JSON input" when connecting to non-loopback IP addresses via-Hflag.Root Cause
Duplicate
c.Redirect()calls in RedirectIfNotLeader middleware (lines 78-79):This creates an invalid redirect URL causing empty/malformed responses.
Solution
Remove the duplicate second redirect call (line 79).
Changes
Fixes #266