[Testing][QDP] f32 Parquet fidelity tests and benchmark#1422
Merged
Conversation
Contributor
Author
|
cc @rich7420 |
… into test-1342-Parquet_f32
Contributor
|
@0lai0 thanks for the patch! Two small nits, neither blocking:
|
rich7420
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #1342
Part of #1338
Changes
Why
The f32 Parquet pipeline (A1–A3) lacked dedicated end-to-end fidelity coverage and throughput validation. Without tests, regressions in the f32 reader or dispatch path could go undetected, and without a benchmark, the expected 25–35% throughput improvement over the f64 path for native f32 columns remained unmeasured.
How
qdp-core/tests/parquet_f32_fidelity.rs: End-to-end f32-vs-f64 fidelity test for the Parquet pipeline.List<Float32>/List<Float64>, read through matching readers, encoded with f32/f64 kernels, compared viafidelity_cross_precision. Thresholds matchgpu_fidelity.rs(1e-3 at 8–16 qubits; amplitude f32 norm precision — the issue's "≥0.99999 where applicable" does not apply here).qdp-core/tests/common/mod.rs: SharedList<Float32>/List<Float64>Parquet writers for fidelity fixtures.qdp-python/benchmark/benchmark_parquet_f32.py+README.md: Optional local/GPU throughput benchmark (vec/s + f32/f64 speedup). Default run generates separate native f32 and f64 files so the f32 path exercises zero-copy native read;--parquet PATHbenchmarks a single user file at both dtypes. Not wired into CI..github/workflows/python-testing.yml: Runparquet_f32(existing [Feature] ParquetReader: f32/f64 columns + Arrow cast #1340 reader acceptance) andparquet_f32_fidelityin therust-checkjob underQDP_NO_CUDA=1. CPU smoke asserts; GPU cases skip without a GPU. Scoped to these two binaries — othergpu_*.rstests lack probe-skip and would fail on the stub.Checklist