Remove the Solaris/SPARC/SunOS support from Netbeans.

[BradWalker]

Remove the Solaris/SPARC/SunOS support from Netbeans.

It's been deprecated since JDK15.
No one has stepped up to support it.
There is no reason to have platform-specific support in Netbeans.

Therefore, remove it.

[lkishalmi]

Hmm. It seems NB is working fine on recent SunOS 5.11...

[neilcsmith-net]

It would appear news of SunOS's death is somewhat premature! 😆

I would also question why pick on that over Windows 95, for example. I think there is something to look at here though. Why not deprecate all the OS constants and masks, as well as the getOperatingSystem() method? Then concentrate on moving everything to isWindows(), isMac(), and isUnix() across the code base?

Note, if you add labels after opening a PR, make sure to use the lock/unlock conversation trick to get the new labels picked up in a new test run.

[mbien]

also cool that OpenIndiana has the latest version of NetBeans in their repo https://repology.org/project/netbeans/versions (even Arch is struggling to achieve that)

Would be a shame to drop Solaris support just to shrink some if-chains.

btw: This PR as of now would be also incomplete. The title, description and commit msg reads like complete removal, while there would be still a lot more Solaris specific code in the repo&release.

[xmhd]

OpenJDK is available on illumos (SunOS) and is actively maintained [1] by @ptribble

I use Netbeans on illumos regularly. What do we achieve by removing this code?

[1] https://github.com/ptribble/jdk-sunos-patches

[ptribble]

Remove the Solaris/SPARC/SunOS support from Netbeans.

It's been deprecated since JDK15. No one has stepped up to support it. There is no reason to have platform-specific support in Netbeans.

Therefore, remove it.

As the person who has stepped up to support OpenJDK on Solaris and illumos, including SPARC, I can say that the above statement is incorrect.

Not only that, Oracle themselves supply JDK17 builds for Solaris on SPARC.

These are platforms which are actively maintained, even if out of tree, and Netbeans is packaged and used in some of the illumos distributions.

[mbien]

@xmhd @ptribble good to hear Solaris is still being maintained via OpenIndiana/illumos (and also that NetBeans is in its repo too). If you encounter any issues, feel free to file them (although no promise that they will be fixed). Some features might not work but NB should at least try to handle those situations gracefully.

@lkishalmi thanks for testing ;)

going to close this PR based on the comments

[BradWalker]

Hey @mbien , I'm okay with closing this PR. This PR does NOT prevent Netbeans from being executed on a Solaris platform. It simply cleans up old dead code that no longer gets executed.

For example, my first changes deals with getProcessMemoryFootPrint() where I removed the Solaris check. IF this code was ever executed it would have called into getProcessMemoryFootPrintOnUnix() which definitely would have thrown an exception as there is no memory-measurement.unix.sh script.

There are other examples of how this code does not preclude one from executing on Solaris.

It's great there are people out there who actively support Java on Solaris. @xmhd & @ptribble . These changes should not effect how Netbeans is supported on Solaris.

Again, I'm okay with closing this PR. As I probably did a poor job of explaining the motivation of what I was trying to accomplish here. And that's on me.