Repository navigation
Support for language-configuration.json #9749
+5,898
−28
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| { | ||
| "comments": { | ||
| "lineComment": "//", | ||
| "blockComment": [ | ||
| "/*", | ||
| "*/" | ||
| ] | ||
| }, | ||
| "brackets": [ | ||
| [ | ||
| "{", | ||
| "}" | ||
| ], | ||
| [ | ||
| "[", | ||
| "]" | ||
| ], | ||
| [ | ||
| "(", | ||
| ")" | ||
| ] | ||
| ], | ||
| "autoClosingPairs": [ | ||
| { | ||
| "open": "[", | ||
| "close": "]" | ||
| }, | ||
| { | ||
| "open": "{", | ||
| "close": "}" | ||
| }, | ||
| { | ||
| "open": "(", | ||
| "close": ")" | ||
| }, | ||
| { | ||
| "open": "'", | ||
| "close": "'", | ||
| "notIn": [ | ||
| "string", | ||
| "comment" | ||
| ] | ||
| }, | ||
| { | ||
| "open": "\"", | ||
| "close": "\"", | ||
| "notIn": [ | ||
| "string" | ||
| ] | ||
| }, | ||
| { | ||
| "open": "/*", | ||
| "close": "*/", | ||
| "notIn": [ | ||
| "string", | ||
| "comment" | ||
| ] | ||
| }, | ||
| { | ||
| "open": "/**", | ||
| "close": " */", | ||
| "notIn": [ | ||
| "string" | ||
| ] | ||
| } | ||
| ], | ||
| "surroundingPairs": [ | ||
| [ | ||
| "{", | ||
| "}" | ||
| ], | ||
| [ | ||
| "[", | ||
| "]" | ||
| ], | ||
| [ | ||
| "(", | ||
| ")" | ||
| ], | ||
| [ | ||
| "\"", | ||
| "\"" | ||
| ], | ||
| [ | ||
| "'", | ||
| "'" | ||
| ], | ||
| [ | ||
| "<", | ||
| ">" | ||
| ] | ||
| ], | ||
| "wordPattern": "(-?\\d*\\.\\d\\w*)|([^\\`\\~\\!\\@\\#\\%\\^\\&\\*\\(\\)\\-\\=\\+\\[\\{\\]\\}\\\\\\|\\;\\:\\'\\\"\\,\\.\\<\\>\\/\\?\\s]+)", | ||
| "folding": { | ||
| "markers": { | ||
| "start": "^\\s*#\\s*pragma\\s+region\\b", | ||
| "end": "^\\s*#\\s*pragma\\s+endregion\\b" | ||
| } | ||
| }, | ||
| "indentationRules": { | ||
| "decreaseIndentPattern": { | ||
| "pattern": "^\\s*[\\}\\]\\)].*$" | ||
| }, | ||
| "increaseIndentPattern": { | ||
| "pattern": "^.*(\\{[^}]*|\\([^)]*|\\[[^\\]]*)$" | ||
| }, | ||
| }, | ||
| "onEnterRules": [ | ||
| { | ||
| // Decrease indentation after single line if/else if/else, for, or while | ||
| "previousLineText": "^\\s*(((else ?)?if|for|while)\\s*\\(.*\\)\\s*|else\\s*)$", | ||
| // But make sure line doesn't have braces or is not another if statement | ||
| "beforeText": "^\\s+([^{i\\s]|i(?!f\\b))", | ||
| "action": { | ||
| "indent": "outdent" | ||
| } | ||
| }, | ||
| // Add // when pressing enter from inside line comment | ||
| { | ||
| "beforeText": "^\\s*//\\s*\\S|\\s//\\s+\\S", | ||
| "afterText": "^(?!\\s*$)", | ||
| "action": { | ||
| "indent": "none", | ||
| "appendText": "// " | ||
| } | ||
| }, | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
|
jtulach marked this conversation as resolved.
Resolved
|
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.netbeans.modules.lsp.client.api; | ||
|
|
||
| import java.lang.annotation.ElementType; | ||
| import java.lang.annotation.Repeatable; | ||
| import java.lang.annotation.Target; | ||
|
|
||
| /**Register a {@code language-configuration.json} for a given mime type. | ||
| * | ||
| * Will also register language features defined in {@link LanguageFeatures} | ||
| * as appropriate. | ||
| * | ||
| * <p>Also consider using <a href="@TOP@../org-netbeans-modules-textmate-lexer/org/netbeans/modules/textmate/lexer/api/GrammarRegistration.html">GrammarRegistration</a> | ||
| * | ||
| * @since 1.38 | ||
| */ | ||
| @Repeatable(LanguageConfigurationRegistrations.class) | ||
| @Target({ElementType.PACKAGE, ElementType.TYPE}) | ||
| public @interface LanguageConfigurationRegistration { | ||
| /** The mime-type under which the grammar should be registered. | ||
| * | ||
| * @return mime-type | ||
| */ | ||
| public String mimeType(); | ||
|
|
||
| /** The language configuration to register. | ||
| * | ||
| * @return language configuration | ||
| */ | ||
| public String languageConfiguration(); | ||
|
Contributor
There was a problem hiding this comment.
|
||
|
|
||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
netbeans/java/kotlin.editor/src/org/netbeans/modules/kotlin/editor/KtDataObject.java
Lines 39 to 48 in e337e53
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GrammarRegistration?languageConfigurationattribute to@GrammarRegistration?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, the language configuration and grammars are independent (after all, they are two independent files). I admit that in practice, it is hard to image a language configuration for a language with a non-Textmate lexer lexer, so, in practice, these are likely to be used together.
I am, however, not convinced that putting "language configuration" into "GrammarRegistration" is appropriate: the language configuration is not really a grammar, and it is certainly not a place where I would look for the registration of the language configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was suggesting another attribute, not putting both into the same file...
Yeah, that was the reason why I wanted to collocate them.
If you think collocating them isn't appropriate then at least hyperlink them in Javadoc strongly suggesting to implement both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider expanding the Kotlin language support with
language-configuration.jsontoo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, but they are still separate files with separate, although connected, purposes. We have plenty of other separate annotations on the DatObjects - should extension and icon definition also be merged as optional attributes into GrammarRegistration? Because the link between an extension, icon and grammar is not much weaker than between the language configuration and the grammar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this PR is an appropriate venue for this. I can remove the C/C++ language configuration and keep just the actual effective code if adding C/C++ config is seen as inappropriate here.