NIFI-15779 Allow error message to appear on controller service ui when service is enabling but not valid - #11182
NIFI-15779 Allow error message to appear on controller service ui when service is enabling but not valid#11182NissimShiman wants to merge 1 commit into
Conversation
…n service is enabling but not valid
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for proposing this change @NissimShiman. This introduces some arbitrary delay numbers, and although the comments are helpful, this appears to revert back to some previous behavior. In addition, the change to declare the message before completeExceptionally() does not appear to be needed.
Rather than introducing this approach, it seems like some other strategy could provide a better way of surfacing enabling failures.
|
Thank you @exceptionfactory for looking at this. Could converting LOG.warn() to componentLog.warn() be a better approach? |
|
@exceptionfactory Could you look at #11389 ? This is a different approach/PR for this. |
|
Thanks for the work on this @NissimShiman. The changes in #11461 accomplished the same goal, so I'm closing this pull request given that those changes have been merged. |
Summary
NIFI-15779
Besides the specific case in the jira, this is useful for cases where a controller service is ghosted or is using an invalid property value (as a result of a migration) and the service is trying to enable but is invalid.
There is now an error icon next to the controller service.
Logic was added to keep the logging manageable, as the framework retries to enable the service.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation