NIFI-16137 - Support externally-supplied client assertion in JWTBearerOAuth2AccessTokenProvider - #11463
Open
pvillard31 wants to merge 1 commit into
Open
NIFI-16137 - Support externally-supplied client assertion in JWTBearerOAuth2AccessTokenProvider#11463pvillard31 wants to merge 1 commit into
pvillard31 wants to merge 1 commit into
Conversation
…rOAuth2AccessTokenProvider
exceptionfactory
requested changes
Aug 3, 2026
exceptionfactory
left a comment
exceptionfactory
left a comment
Contributor
There was a problem hiding this comment.
Thanks @pvillard31, this looks like a straightforward improvement. I noted a few minor implementation details, then this should be ready to go.
|
|
||
| @Override | ||
| public String getValue() { | ||
| return displayName; |
Contributor
There was a problem hiding this comment.
This should be changed to name()
| return description; | ||
| } | ||
|
|
||
| public static Optional<AssertionStrategy> fromValue(final String value) { |
Contributor
There was a problem hiding this comment.
Is this method necessary?
Comment on lines
+128
to
+131
| Determines how the RFC 7523 JWT assertion presented to the Token Endpoint is produced: either | ||
| built and signed locally using a Private Key Service, or supplied by an external | ||
| OAuth2AccessTokenProvider whose token is used directly as the assertion. | ||
| """) |
Contributor
There was a problem hiding this comment.
The description should be shortened to avoid duplicating the descriptions of each value
| JWSAlgorithm.Ed25519.getName()) | ||
| .defaultValue(JWSAlgorithm.PS256.getName()) | ||
| .required(true) | ||
| .dependsOn(ASSERTION_STRATEGY, AssertionStrategy.SELF_SIGNED.getValue()) |
Contributor
There was a problem hiding this comment.
It should be possible to remove getValue() from this and other references in dependOn
Comment on lines
+399
to
+400
| final AssertionStrategy strategy = AssertionStrategy.fromValue(validationContext.getProperty(ASSERTION_STRATEGY).getValue()) | ||
| .orElse(AssertionStrategy.SELF_SIGNED); |
Contributor
There was a problem hiding this comment.
This should use asAllowableValue()
Comment on lines
+630
to
+631
| final AssertionStrategy strategy = AssertionStrategy.fromValue(context.getProperty(ASSERTION_STRATEGY).getValue()) | ||
| .orElse(AssertionStrategy.SELF_SIGNED); |
Contributor
There was a problem hiding this comment.
This should use asAllowableValue() instead of the fromValue helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16137 - Support externally-supplied client assertion in JWTBearerOAuth2AccessTokenProvider
The idea is to support a scenario like:
I tested the changes locally and can provide some screenshot if helpful.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation