NIFI-16157: Add millis to formatDurationToWords - #11496
Merged
exceptionfactory merged 1 commit intoAug 3, 2026
Merged
Conversation
ohnoitsyou
force-pushed
the
NIFI-16157_utils-format-missing-units
branch
from
August 3, 2026 14:30
976a3fe to
85a5945
Compare
Missed adding 'ms' to the initial implementation. Updated implementation to include down to seconds by default and include sub-seconds if present Sub-seconds follow reverse, higher units included if lower unit present
ohnoitsyou
force-pushed
the
NIFI-16157_utils-format-missing-units
branch
from
August 3, 2026 19:29
85a5945 to
b0d7641
Compare
exceptionfactory
approved these changes
Aug 3, 2026
exceptionfactory
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this improvement @ohnoitsyou! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed adding 'ms' to the initial implementation.
Updated implementation to include down to seconds by default and include
sub-seconds if present
Sub-seconds follow reverse, higher units included if lower unit present
Summary
NIFI-16157
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation