apps: decouple signal support by extinguish · Pull Request #3217 · apache/nuttx-apps

extinguish · 2025-11-20T13:16:10Z

Summary

Added support for signal decoupling, primarily involving modifications to the following modules in the apps: ostest, nsh/tools, netutils, and the cu tool.

ostest: When CONFIG_DISABLE_SIGNALS=y, certain tests that rely on signal functionality need to be disabled.
nsh/tools: Functionalities dependent on the signal module have been made configurable, allowing most parts of nsh to remain usable even when CONFIG_DISABLE_SIGNALS=y.
netutils: Ensures basic usability of certain network functionalities when signals are disabled.
cu tool: Refactored portions of the cu module implementation to maintain its usability under signal-disabled conditions.

Impact

No adjustments were made to the functional logic; support was only added for when CONFIG_DISABLE_SIGNALS=y.

Testing

has passed the ostest

1. sigprocmask_test/sighand_test/signest_test/suspend_test: these testcases are using to test the signal api 2. sigev_thread_test: this testcase need to access signal related function 3. timer_test: this testcase need to access signal related function Signed-off-by: guoshichao <guoshichao@xiaomi.com>

make the nsh tools can work with SIGNAL disabled Signed-off-by: guoshichao <guoshichao@xiaomi.com>

using pthread_cancel to implement the exit logic, thus to make the netutils tools can work when signal disabled Signed-off-by: guoshichao <guoshichao@xiaomi.com>

using the local cu_globals_s instance to manange the cu exit procedure Signed-off-by: guoshichao <guoshichao@xiaomi.com>

merge the cu.h to cu_main.c, to make the cu tools code more cleaner Signed-off-by: guoshichao <guoshichao@xiaomi.com>

The core functionality of the cu tool does not rely on signal features. Therefore, we can isolate the signal-related implementations to ensure that most functions of the cu tool remain operational even when signals are disabled. Signed-off-by: guoshichao <guoshichao@xiaomi.com>

The commit 'add support for CONFIG_DISABLE_SIGNALS' led to: undefined reference to `signal' undefined reference to `sigaction' Signed-off-by: v-tangmeng <v-tangmeng@xiaomi.com>

…GNALS The commit 'add support for CONFIG_DISABLE_SIGNALS' led to: undefined reference to `sigaction' Signed-off-by: v-tangmeng <v-tangmeng@xiaomi.com>

cederom

Thank you @extinguish great work!

This PR is a prototype for testing and goes in pair with apache/nuttx#17352. Needs careful review and testing. When parent PR is merged this one goes in pair :-)

I am just marking RC here not to merge by accident :-)

xiaoxiang781216 · 2025-11-24T08:42:11Z

Thank you @extinguish great work!

This PR is a prototype for testing and goes in pair with apache/nuttx#17352. Needs careful review and testing. When parent PR is merged this one goes in pair :-)

I am just marking RC here not to merge by accident :-)

@cederom this patch need be merged first to unlock ci error on apache/nuttx#17352. If the community accept to add DISABLE_SIGNALS option, it's better to merge this simple pr first, so we can ensure the kernel side change don't break any build.

acassis · 2025-11-24T10:56:06Z

@xiaoxiang781216 Do you know if @extinguish is doing it coordinated with @wangchdo ? Otherwise we will have many issues.

xiaoxiang781216 · 2025-11-24T11:21:32Z

@xiaoxiang781216 Do you know if @extinguish is doing it coordinated with @wangchdo ? Otherwise we will have many issues.

@extinguish 's userspace change is the subset of @wangchdo 's since @wangchdo disable the full signal feature.

xiaoxiang781216 · 2025-11-25T02:05:47Z

If the community agree to disable signal with option, it's better to merge this pr first, so both @extinguish and @wangchdo 's change can move forward and verify with ci. @cederom @acassis

acassis · 2025-11-25T10:30:30Z

@extinguish there are some errors, i.e.:

Configuration/Tool: lm3s6965-ek/qemu-protected,CONFIG_ARM_TOOLCHAIN_GNU_EABI
2025-11-25 09:18:02
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Building NuttX...
arm-none-eabi-ld: /github/workspace/sources/nuttx/staging//libapps.a(test_symtab.o):(.rodata.g_elf_exports+0xe4): undefined reference to `register_driver'
arm-none-eabi-ld: /github/workspace/sources/nuttx/staging//libapps.a(test_symtab.o):(.rodata.g_elf_exports+0x15c): undefined reference to `unregister_driver'
make[1]: *** [Makefile:61: nuttx_user.elf] Error 1
make[1]: Target 'all' not remade because of errors.
make: *** [tools/Unix.mk:541: nuttx] Error 2
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory

extinguish · 2025-11-25T13:10:41Z

@extinguish there are some errors, i.e.:

Configuration/Tool: lm3s6965-ek/qemu-protected,CONFIG_ARM_TOOLCHAIN_GNU_EABI
2025-11-25 09:18:02
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Building NuttX...
arm-none-eabi-ld: /github/workspace/sources/nuttx/staging//libapps.a(test_symtab.o):(.rodata.g_elf_exports+0xe4): undefined reference to `register_driver'
arm-none-eabi-ld: /github/workspace/sources/nuttx/staging//libapps.a(test_symtab.o):(.rodata.g_elf_exports+0x15c): undefined reference to `unregister_driver'
make[1]: *** [Makefile:61: nuttx_user.elf] Error 1
make[1]: Target 'all' not remade because of errors.
make: *** [tools/Unix.mk:541: nuttx] Error 2
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory

this is fixed in updated pull request

xiaoxiang781216 · 2025-11-25T15:22:36Z

@extinguish but the same error still report.

extinguish · 2025-11-26T01:30:05Z

@extinguish but the same error still report.

Got it, I'm fixing it now, this is a new issue introduced by supporting the protect build process for mksym_tab.c.

extinguish · 2025-11-27T01:54:44Z

@extinguish but the same error still report.

the "examples/elf project refactor and disable signal procedure" is separate to a new pull request, and the new pull request is based on #3223, after #3223 is review passed and merged, the examples/elf refactor pull request will upstreaming

xiaoxiang781216 · 2026-01-13T04:38:32Z

@extinguish please keep cu change which isn't related to signal.

xiaoxiang781216 · 2026-01-13T07:34:37Z

close tracked by #3314 and #3265.

github-actions Bot added Area: Networking Area: System Area: Testing Area: NSH Size: M labels Nov 20, 2025

extinguish force-pushed the apps_signal_decouple branch from fc21c7e to 9845726 Compare November 21, 2025 02:02

extinguish added 6 commits November 21, 2025 10:36

nsh/tools: add support for DISABLE_SIGNALS

9b75138

make the nsh tools can work with SIGNAL disabled Signed-off-by: guoshichao <guoshichao@xiaomi.com>

netutils: make the net tools can work with signal disabled

21eba6b

using pthread_cancel to implement the exit logic, thus to make the netutils tools can work when signal disabled Signed-off-by: guoshichao <guoshichao@xiaomi.com>

cu: implement the cu exit logic like top cmd

3d74819

using the local cu_globals_s instance to manange the cu exit procedure Signed-off-by: guoshichao <guoshichao@xiaomi.com>

cu: merge the cu.h to cu_main.c

744eed5

merge the cu.h to cu_main.c, to make the cu tools code more cleaner Signed-off-by: guoshichao <guoshichao@xiaomi.com>

extinguish force-pushed the apps_signal_decouple branch from 9845726 to 67dd5d2 Compare November 21, 2025 02:37

TangMeng12 added 2 commits November 21, 2025 11:22

examples: fix the compilation error caused by CONFIG_DISABLE_SIGNALS

107b636

The commit 'add support for CONFIG_DISABLE_SIGNALS' led to: undefined reference to `signal' undefined reference to `sigaction' Signed-off-by: v-tangmeng <v-tangmeng@xiaomi.com>

examples/timer: fix the compilation error caused by CONFIG_DISABLE_SI…

15ca04b

…GNALS The commit 'add support for CONFIG_DISABLE_SIGNALS' led to: undefined reference to `sigaction' Signed-off-by: v-tangmeng <v-tangmeng@xiaomi.com>

github-actions Bot added the Area: Examples label Nov 21, 2025

extinguish mentioned this pull request Nov 21, 2025

Support disable signal apache/nuttx#17357

Closed

xiaoxiang781216 approved these changes Nov 24, 2025

View reviewed changes

xiaoxiang781216 requested review from acassis and jerpelea November 24, 2025 06:05

cederom requested changes Nov 24, 2025

View reviewed changes

cederom mentioned this pull request Nov 24, 2025

sched/signal: Add support to disable signals apache/nuttx#17352

Closed

xiaoxiang781216 previously approved these changes Nov 25, 2025

View reviewed changes

extinguish dismissed xiaoxiang781216’s stale review via ab0054a November 25, 2025 06:15

extinguish force-pushed the apps_signal_decouple branch from ab0054a to 69ee29e Compare November 25, 2025 06:55

github-actions Bot added the Size: XL label Nov 25, 2025

xiaoxiang781216 approved these changes Nov 25, 2025

View reviewed changes

jerpelea changed the title ~~add signal decouple support~~ apps: decouple signal support Nov 25, 2025

jerpelea previously approved these changes Nov 25, 2025

View reviewed changes

xiaoxiang781216 previously approved these changes Nov 25, 2025

View reviewed changes

extinguish dismissed stale reviews from xiaoxiang781216 and jerpelea via c97bb67 November 25, 2025 13:09

github-actions Bot added the Area: Tools label Nov 25, 2025

extinguish force-pushed the apps_signal_decouple branch from c97bb67 to 15ca04b Compare November 27, 2025 01:42

github-actions Bot removed the Area: Tools label Nov 27, 2025

xiaoxiang781216 approved these changes Nov 27, 2025

View reviewed changes

xiaoxiang781216 closed this Jan 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

apps: decouple signal support#3217

apps: decouple signal support#3217
extinguish wants to merge 8 commits intoapache:masterfrom
extinguish:apps_signal_decouple

extinguish commented Nov 20, 2025 •

edited by cederom

Loading

Uh oh!

cederom left a comment

Uh oh!

xiaoxiang781216 commented Nov 24, 2025 •

edited

Loading

Uh oh!

acassis commented Nov 24, 2025

Uh oh!

xiaoxiang781216 commented Nov 24, 2025

Uh oh!

xiaoxiang781216 commented Nov 25, 2025 •

edited

Loading

Uh oh!

acassis commented Nov 25, 2025

Uh oh!

extinguish commented Nov 25, 2025

Uh oh!

xiaoxiang781216 commented Nov 25, 2025 •

edited

Loading

Uh oh!

extinguish commented Nov 26, 2025

Uh oh!

extinguish commented Nov 27, 2025

Uh oh!

xiaoxiang781216 commented Jan 13, 2026

Uh oh!

xiaoxiang781216 commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

extinguish commented Nov 20, 2025 • edited by cederom Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Impact

Testing

Uh oh!

cederom left a comment

Choose a reason for hiding this comment

Uh oh!

xiaoxiang781216 commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acassis commented Nov 24, 2025

Uh oh!

xiaoxiang781216 commented Nov 24, 2025

Uh oh!

xiaoxiang781216 commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acassis commented Nov 25, 2025

Uh oh!

extinguish commented Nov 25, 2025

Uh oh!

xiaoxiang781216 commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

extinguish commented Nov 26, 2025

Uh oh!

extinguish commented Nov 27, 2025

Uh oh!

xiaoxiang781216 commented Jan 13, 2026

Uh oh!

xiaoxiang781216 commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

extinguish commented Nov 20, 2025 •

edited by cederom

Loading

xiaoxiang781216 commented Nov 24, 2025 •

edited

Loading

xiaoxiang781216 commented Nov 25, 2025 •

edited

Loading

xiaoxiang781216 commented Nov 25, 2025 •

edited

Loading