nshlib: Add vconfig command#3286
Merged
xiaoxiang781216 merged 2 commits intoapache:masterfrom Jan 8, 2026
Merged
Conversation
HedongGao
force-pushed
the
c62edd1
branch
2 times, most recently
from
e5e7cbb to
cb7132d
Compare
xiaoxiang781216
previously approved these changes
Dec 29, 2025
Contributor
|
Please add documetation. |
xiaoxiang781216
previously approved these changes
Jan 7, 2026
Contributor
|
@HedongGao please remove the merge patch from pr. |
Contributor
@cederom here is apache/nuttx#17790 |
cederom
previously approved these changes
Jan 7, 2026
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @HedongGao :-)
HedongGao
dismissed stale reviews from cederom and xiaoxiang781216
via
0428112
Add vconfig command Signed-off-by: gaohedong <gaohedong@xiaomi.com>
Now we allow setting a default PCP when creating VLAN like: `vconfig add iface-name vlan-id [pcp]` e.g. `vconfig add eth0 10` will create eth0.10 with VID=10 and no PCP(0) `vconfig add eth0 10 3` will create eth0.10 with VID=10 and PCP=3 Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
Contributor
Author
Done! |
xiaoxiang781216
approved these changes
Jan 8, 2026
cederom
approved these changes
Jan 8, 2026
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @HedongGao :-) Lets just make sure CI builds fine :-)
jerpelea
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With reference to the implementation of vconfig in Linux, a vconfig tool is added, through which you can configure the vlan interface.
Control whether the tool is enabled by compiling options CONFIG_NET_VLAN and CONFIG_NSH_DISABLE_VCONFIG.
Impact
The user can configure the vlan interface through this interface.
Testing
Open the compilation options CONFIG_NET_VLAN and CONFIG_NSH_DISABLE_VCONFIG. Add/delete the Vlan interface in the SIM environment, and check whether the configuration is successful through ifconfig.