-
Notifications
You must be signed in to change notification settings - Fork 1.4k
sched/hrtimer: hrtimer state machine improvement for SMP cases #17642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wangchdo
wants to merge
5
commits into
apache:master
Choose a base branch
from
wangchdo:refine_hrtimer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+156
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
742782b to
f475319
Compare
f475319 to
7c27ef8
Compare
7c27ef8 to
6ba659c
Compare
b1ed47e to
c91948a
Compare
c91948a to
dc9a2b7
Compare
dc9a2b7 to
bc161b5
Compare
acassis
previously approved these changes
Dec 23, 2025
Allow running/armed hrtimer to be restarted to fix hrtimer bug: apache#17567 Signed-off-by: Chengdong Wang <[email protected]>
Update the hrtimer documentation to describe the hrtimer state machine, which is introduced to handle safe cancellation and execution in SMP environments. Signed-off-by: Chengdong Wang <[email protected]>
Improve hrtimer to only enable SMP related logic when in SMP mode to improve performance in non-SMP mode Signed-off-by: Chengdong Wang <[email protected]>
bc161b5 to
3c3b7a4
Compare
Contributor
Author
Replace spinlock with seqlock to improve performance Signed-off-by: Chengdong Wang <[email protected]>
7b9caba to
11a7fa7
Compare
Disable hrtimer state machine when in non SMP to improve performance Signed-off-by: Chengdong Wang <[email protected]>
b8ea392 to
d1b174b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Documentation
Improvements or additions to documentation
Area: OS Components
OS Components issues
Size: M
The size of the change in this PR is medium
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is also included in #17573. Since #17573 covers both overall scheduler support with hrtimer and related hrtimer improvements for SMP mode, and since hrtimer is an independent module, this change is submitted separately to focus on hrtimer improvements and avoid conflicts with other scheduler-related enhancements such as #17640.
This PR refines the hrtimer state machine to allow ARMED and RUNNING hrtimers to be safely restarted, and fixes several corner-case issues in SMP mode.
The updated hrtimer state machine is shown below and is also documented in the hrtimer module documentation:
Impact
Improments for the hrtimer module
Testing
Test 1 passed (integrated in ostest):
- test implementation:
test log on rv-virt:smp64:
test 2 passed (provided by @Fix-Point )
test implementation
test passed log on rv-virt:smp64
test 3 passed (provided by @Fix-Point )
test implementation
test passed log on rv-virt:smp64
test 4 passed (provided by @Fix-Point )
test implementation
test passed log on rv-virt:smp64