net/icmp: Return -ENOPROTOOPT for SOL_SOCKET to avoid misleading logs#17662
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Dec 25, 2025
Merged
net/icmp: Return -ENOPROTOOPT for SOL_SOCKET to avoid misleading logs#17662xiaoxiang781216 merged 1 commit intoapache:masterfrom
xiaoxiang781216 merged 1 commit intoapache:masterfrom
Conversation
When SOL_SOCKET options (e.g., SO_BINDTODEVICE via ping -I) hit ICMP sockets, icmp_{get,set}sockopt logged “Unrecognized ICMP option: 17” before fallback. Handle SOL_SOCKET explicitly by returning -ENOPROTOOPT so psock_* routes to the socket-level handler. Removes noisy logs without changing behavior (invalid devices still return -ENODEV).
Signed-off-by: wangchen <wangchen41@xiaomi.com>
wangchen61698
requested review from
jerpelea and
xiaoxiang781216
as code owners
github-actions
Bot
added
Area: Networking
xiaoxiang781216
previously approved these changes
Dec 24, 2025
linguini1
previously approved these changes
Dec 24, 2025
wangchen61698
dismissed stale reviews from linguini1 and xiaoxiang781216
via
085910e
github-actions
Bot
added
Area: Documentation
github-actions
Bot
removed
the
Area: Documentation
xiaoxiang781216
approved these changes
Dec 25, 2025
linguini1
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
When SOL_SOCKET options (e.g., SO_BINDTODEVICE via ping -I) hit ICMP sockets, icmp_{get,set}sockopt logged “Unrecognized ICMP option: 17” before fallback. Handle SOL_SOCKET explicitly by returning -ENOPROTOOPT so psock_* routes to the socket-level handler. Removes noisy logs without changing behavior (invalid devices still return -ENODEV).
Impact
icmp log
Testing
Please verify this PR together with another PR
apache/nuttx-apps#3263
After patch
Before patch