python: remove tabs and indent with spaces#422
Draft
jbampton wants to merge 3 commits intoapache:trunkfrom
Draft
python: remove tabs and indent with spaces#422jbampton wants to merge 3 commits intoapache:trunkfrom
jbampton wants to merge 3 commits intoapache:trunkfrom
Conversation
https://peps.python.org/pep-0008/#indentation PEP 8 – Style Guide for Python Code Use 4 spaces per indentation level. https://peps.python.org/pep-0008/#tabs-or-spaces Python disallows mixing tabs and spaces for indentation.
Member
|
Maybe we should add some kind of vim modeline to Python files? |
Member
Author
|
We could use black to standardize all the Python code to one format. Then we don't have worry about nit picking in future and just focus on real changes. Might be similar to adding pre-commit and take a while over many PRs targeting different folders or code etc. Probably not advisable to just mass format in one go. We can add black to pre-commit and I have done this already on other projects |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://peps.python.org/pep-0008/#indentation
PEP 8 – Style Guide for Python Code
Use 4 spaces per indentation level.
https://peps.python.org/pep-0008/#tabs-or-spaces
Python disallows mixing tabs and spaces for indentation.