Add a copyright messaging to the BpackingAvx512.hh#1691
Add a copyright messaging to the BpackingAvx512.hh#1691guangzegu wants to merge 1 commit intoapache:mainfrom
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making a PR, @guangzegu .
Actually, here is the ASF legal policy.
Do not add the standard Apache License header to the top of third-party source files.
If this file falls into third-party source file, we need to remove ASF License.
cc @wpleonardo as the author of this PR.
cc @wgtmac , @williamhyun , @stiga-huang , @coderex2522 from #1375 reviewers.
| */ | ||
|
|
||
| /******************************************************************************* | ||
| * Copyright (C) 2022 Intel Corporation |
There was a problem hiding this comment.
Could you give us the original source link?
|
If we need to regard the code as third-party and remove ASF license header, some refactoring work is required to isolate code from Intel QPL and then add the copyright. It seems that |
It would be even better if you could provide the original source of the code. |
The source code link: https://github.com/intel/qpl/blob/c2ced94c53c1ee22191201a59878e9280bc9b9b8/sources/core-sw/src/filtering/opt/qplc_unpack_be_8u_k0.h#L158 |
|
@wpleonardo Sorry to hear that |
What changes were proposed in this pull request?
Add copyright messaging to BpackingAvx512.hh
Why are the changes needed?
The vector unpacking functions in this PR https://github.com/apache/orc/pull/1375 is derived from Intel's QPL library, hence, Maybe copyright messaging should be added.
QPL Link: https://github.com/intel/qpl
How was this patch tested?
N/A