Skip to content

Conversation

@XiaoHongbo-Hope
Copy link
Contributor

Purpose

Linked issue: close #xxx

Tests

API and Format

Documentation

@XiaoHongbo-Hope XiaoHongbo-Hope marked this pull request as ready for review January 1, 2026 02:43
raise RuntimeError("Primary key should not be null")

data_fields = stats_fields if value_stats_enabled else []
value_stats = self._collect_value_stats(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will collect twice for key fields.

@XiaoHongbo-Hope XiaoHongbo-Hope marked this pull request as draft January 1, 2026 12:21
@XiaoHongbo-Hope XiaoHongbo-Hope marked this pull request as ready for review January 4, 2026 06:56
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit e2591d1 into apache:master Jan 4, 2026
4 checks passed
jerry-024 added a commit to jerry-024/paimon that referenced this pull request Jan 6, 2026
* upstream/master: (35 commits)
  [spark] Spark support vector search (apache#6950)
  [doc] update Apache Doris document with DLF 3.0 (apache#6954)
  [variant] Fix reading empty shredded variant via variantAccess (apache#6953)
  [python] support alterTable (apache#6952)
  [python] support ray data sink to paimon (apache#6883)
  [python] Rename to TableScan.withSlice to specific start_pos and end_pos
  [python] sync to_ray method args with ray data api (apache#6948)
  [python] light refactor for stats collect (apache#6941)
  [doc] Update cdc ingestion related docs
  [rest] Add tagNamePrefix definition for listTagsPaged (apache#6947)
  [python] support table scan with row range (apache#6944)
  [spark] Fix EqualNullSafe is not correct when column has null value. (apache#6943)
  [python] fix value_stats containing system fields for primary key tables (apache#6945)
  [test][rest] add test case for two sessions with cache for rest commitTable (apache#6438)
  [python] do not retry for connect exception in rest (apache#6942)
  [spark] Fix read shredded and unshredded variant both (apache#6936)
  [python] Let Python write file without value stats by default (apache#6940)
  [python] ray version compatible (apache#6937)
  [core] Unify conflict detect in FileStoreCommitImpl (apache#6932)
  [test] Fix unstable case in CompactActionITCase
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants