Rename parquet.thrift to parquet.format#554
Draft
usvip777-sys wants to merge 1 commit intoapache:masterfrom
Draft
Rename parquet.thrift to parquet.format#554usvip777-sys wants to merge 1 commit intoapache:masterfrom
usvip777-sys wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
What is the rationale for this change? |
Contributor
|
I agree -- without a compelling usecase changing this file name I think would cause non trivial downstream churn, as well as being inconsistent with using a |
Contributor
|
Marking as draft as I think this PR is no longer waiting on feedback and I am trying to make it easier to find PRs in need of review. Please mark it as ready for review when it is ready for another look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Do these changes have PoC implementations?