Correct VARIANT Logical Type annotation in Parquet examples#555
Open
Correct VARIANT Logical Type annotation in Parquet examples#555
Conversation
Updated the representation of unshredded and shredded Variants in Parquet to include the variant version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
That the example of the
VARAINTtype annotation in this repository did not have an integer fieldI double checked and the VARAINT logical type does indeed have a integer field ("specification_version"):
parquet-format/src/main/thrift/parquet.thrift
Lines 409 to 413 in 38818fa
This is also consistent with the parquet-java tests:
https://github.com/apache/parquet-java/blob/7148464a6b1a795f0058a811de2215d111b976ce/parquet-avro/src/test/java/org/apache/parquet/avro/TestReadVariant.java#L295
https://github.com/apache/parquet-java/blob/7148464a6b1a795f0058a811de2215d111b976ce/parquet-column/src/test/java/org/apache/parquet/parser/TestParquetParser.java#L455
What changes are included in this PR?
Updated the representation of unshredded and shredded Variants in the example to include the variant version
Do these changes have PoC implementations?
No this does not change the spec at all, just the examples