Fix FileNotFoundException handling in segment download API#17523
Open
rsrkpatwari1234 wants to merge 10 commits intoapache:masterfrom
Open
Fix FileNotFoundException handling in segment download API#17523rsrkpatwari1234 wants to merge 10 commits intoapache:masterfrom
rsrkpatwari1234 wants to merge 10 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@Jackie-Jiang @ankitsultana Requesting your help in running the above workflow and reviewing the changes |
Contributor
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Please fix the test failure
pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/BaseSegmentFetcher.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/BaseSegmentFetcher.java
Outdated
Show resolved
Hide resolved
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
Author
|
@Jackie-Jiang Requesting your review. The test failure seems unrelated to my change |
Contributor
|
I think it is related: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16231
Problem
When the /segments controller API hit a FileNotFoundException (or HTTP 404), it showed these issues:
Solution
In this PR, I have implemented two improvements -
BaseSegmentFetcherandHttpSegmentFetcher, we detect FileNotFoundException (and, for HTTP, HttpErrorStatusException with status 404) in the exception cause chain and rethrow immediately so no retries are performed.PinotSegmentUploadDownloadRestletResource, we catch these cases (viaExceptionUtils.isCauseInstanceOfandgetFirstCauseOfType) and returnResponse.Status.NOT_FOUND(404) instead of 500.Unit Tests
✅ 4 new tests added to verify FileNotFoundException behaviour
✅ All existing tests pass - no breaking changes
bugfix