XDDFDataSourcesFactory.java replace anonymous classes with a real one for clarity #973
+97
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed some inline classes ( because they are hard to debug/understand and are anonymous) and replaced these 4 anon classes with a single real class thereby shrinking code
pjfanning
reviewed
Dec 17, 2025
| public final Type type; | ||
|
|
||
| public XDDFCategoryDataSourceImpl(CTAxDataSource categoryDS) { | ||
| this.categoryDS=categoryDS; |
Contributor
Author
There was a problem hiding this comment.
you mean just around this = sign ?
added whitespaces as required
emmanueldufour
changed the title
pjfanning
requested changes
Dec 18, 2025
Member
There was a problem hiding this comment.
this file has been reformatted - appears to replace the spaces used for indents with tabs, leading to a 100% diff in the file
I will not review this unless the format is fixed. It is not acceptable to reformat files in PRs with code changes - it makes the PR impossible to review.
forgot a couple function
pjfanning
reviewed
Dec 19, 2025
| } | ||
|
|
||
| public boolean isNumeric() { | ||
| return (type == Type.FROM_NUMBER_REFERENCE || type == Type.FROM_NUMBER_LITERAL); |
Member
There was a problem hiding this comment.
code will never be merged unless it is formatted correctly - 4 space indents and no tabs
Contributor
Author
There was a problem hiding this comment.
btw in the future do not let whitespaces hold you back:
https://stackoverflow.com/questions/37007300/how-to-ignore-whitespace-in-github-when-comparing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed some inline classes ( because they are hard to read and debug) and replaced these 4 anon classes with a single real class thereby shrinking code