[fix][client] The input parameters for PulsarPullConsumerImpl have been changed from PulsarAdmin parameters to Supplier format, requiring dynamic updates. - #27
Merged
Conversation
…en changed from PulsarAdmin parameters to Supplier format, requiring dynamic updates.
AnonHxy
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PulsarPullConsumerImplcurrently accepts a fixedPulsarAdmininstance. This is inconsistent with the existingSupplier<PulsarClient>design and prevents the pull consumer from obtaining an updatedPulsarAdmininstance when the underlying client/admin needs to be refreshed dynamically.Modifications
PulsarAdminconstructor parameter inPulsarPullConsumerImplwithSupplier<PulsarAdmin>.getPulsarAdmin()to obtain and validate the currentPulsarAdmininstance when it is needed.PulsarAdminusages, including:PulsarPullConsumerTestcases to passPulsarAdminthrough a supplier.Verifying this change
This change updates existing tests to use the new constructor signature. The existing pull consumer test coverage continues to verify: