[fix][broker] Avoid split non-existent bundle#25031
Merged
lhotari merged 6 commits intoapache:masterfrom Jan 14, 2026
Merged
Conversation
coderzc
changed the title
|
@coderzc Please add the following content to your PR description and select a checkbox: |
github-actions
Bot
added
doc
lhotari
reviewed
Dec 4, 2025
github-actions
Bot
added
doc-not-needed
coderzc
force-pushed
the
fix_split_old_bundle
branch
3 times, most recently
from
e2b577f to
2da2096
Compare
coderzc
force-pushed
the
fix_split_old_bundle
branch
from
2da2096 to
d582d6b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25031 +/- ##
============================================
+ Coverage 74.35% 74.47% +0.11%
+ Complexity 34102 34037 -65
============================================
Files 1920 1899 -21
Lines 150313 149641 -672
Branches 17459 17397 -62
============================================
- Hits 111771 111448 -323
+ Misses 29635 29320 -315
+ Partials 8907 8873 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
coderzc
changed the title
Denovo1998
reviewed
Dec 15, 2025
coderzc
force-pushed
the
fix_split_old_bundle
branch
from
f4ddc6f to
ef61623
Compare
Denovo1998
reviewed
Dec 18, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition where namespace bundles could be split multiple times, causing failures on subsequent split attempts after the bundle has already been removed. The fix adds validation to check if a bundle still exists in the current NamespaceBundles before attempting to split it.
Key Changes:
- Added validation logic to skip splitting bundles that no longer exist in NamespaceBundles
- Changed validateBundle exception signature from generic Exception to more specific IllegalArgumentException
- Added test case to verify repeated split attempts don't cause errors
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ModularLoadManagerImpl.java | Added checkBundleDataExistInNamespaceBundles method to validate bundle existence before split; commented out lock statements in writeBrokerDataOnZooKeeper |
| NamespaceBundles.java | Changed validateBundle to throw IllegalArgumentException instead of generic Exception for better type safety |
| ModularLoadManagerImplTest.java | Added testRepeatSplitBundle test to verify the fix for repeated bundle split attempts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Denovo1998
approved these changes
Jan 11, 2026
lhotari
approved these changes
Jan 14, 2026
lhotari
pushed a commit
that referenced
this pull request
Jan 16, 2026
(cherry picked from commit 38807b1)
lhotari
pushed a commit
that referenced
this pull request
Jan 16, 2026
(cherry picked from commit 38807b1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As you can see from the log, after
0x80000000_0xc0000000was successfully split, it was split again for the second time calling the updateAll() method and failed to split old bundle since bundle been deleted.Modifications
Skip split the bundles that do not exist in NamespaceBundles
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: