[fix][broker] Close protocol handlers channel #25111
Open
+33
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During the shutdown process of Pulsar brokers, protocol handlers' channels are not properly closed, which allows new client requests to continue arriving even after the shutdown has been initiated. This can lead to:
The broker's
closeAsyncmethod properly handles closing all channels by callingchannel.close()on all channels inlistChannels. However, the same pattern is not applied to protocol handlers, leaving their channels open during the shutdown process.Modifications
closeProtocolHandlerChannels()method to properly close all protocol handler channels before callingprotocolHandler.close()closeAsyncVerifying this change
This change is already covered by existing tests, such as:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
[
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
gaozhangmin#14