[improve][pip] PIP-471: Authorization operation metrics#25513
Open
mattisonchao wants to merge 3 commits intomasterfrom
Open
[improve][pip] PIP-471: Authorization operation metrics#25513mattisonchao wants to merge 3 commits intomasterfrom
mattisonchao wants to merge 3 commits intomasterfrom
Conversation
mattisonchao
changed the title
15 tasks
Contributor
|
It should be PIP-468 |
mattisonchao
force-pushed
the
mattison/pip-298-authorization-metrics
branch
from
0703dbd to
c160138
Compare
mattisonchao
changed the title
Member
Author
|
Renumbered this proposal to PIP-471. PIP-466, PIP-467, and PIP-468 are now on master, and PIP-469/PIP-470 are already used by open PIP PRs. |
lhotari
reviewed
May 4, 2026
Comment on lines
+192
to
+193
| | `success` | The authorization request was allowed. | | ||
| | `failure` | The authorization request was denied or rejected by authorization handling. | |
Member
There was a problem hiding this comment.
Since this metric label represents an authorization outcome, could we use allowed/denied instead of success/failure? The explicit values will read more clearly in dashboards and PromQL queries, and avoid ambiguity about what success means here (policy evaluated successfully vs. access granted).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pulsar lacks a generic broker authorization metric model that can be used for alerting, dashboards, and compliance-oriented monitoring. This PIP proposes low-cardinality authorization operation metrics with success, failure, and error results for both Prometheus and OpenTelemetry.
Modifications
pip/pip-471.mdfor authorization operation metrics.pulsar_authorization_operations_total.pulsar.authorization.operation.countand its bounded attributes.result="error"for authorization evaluation errors before an allow/deny decision is returned.Testing
git diff --checkDocumentation
docdoc-requireddoc-not-neededdoc-complete