[fix][common] Clear empty String values in FieldParser#26078
Open
hiSandog wants to merge 1 commit into
Open
Conversation
Assisted-by: OpenAI Codex
nodece
approved these changes
Jun 23, 2026
lhotari
requested changes
Jun 23, 2026
lhotari
reviewed
Jun 23, 2026
Comment on lines
+231
to
232
| } else if (Number.class.isAssignableFrom(field.getType()) || field.getType().equals(String.class)) { | ||
| field.set(obj, null); |
Member
There was a problem hiding this comment.
Suggested change
| } else if (Number.class.isAssignableFrom(field.getType()) || field.getType().equals(String.class)) { | |
| field.set(obj, null); | |
| } else if (Number.class.isAssignableFrom(field.getType())) { | |
| field.set(obj, null); | |
| } else if (String.class.equals(field.getType())) { | |
| field.set(obj, ""); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FieldParser.setEmptyValue is intended to clear String and boxed numeric fields when a configuration property is present but blank. The String branch currently checks fieldType.getClass().equals(String.class), which compares Class.class to String.class and never matches. As a result, an existing String field value is left unchanged when the property value is empty.
Modifications
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts: