Skip to content

RATIS-2435. ratis-bom POM is not signed during release staging#1374

Merged
adoroszlai merged 1 commit intoapache:masterfrom
OneSizeFitsQuorum:jira2435
Mar 13, 2026
Merged

RATIS-2435. ratis-bom POM is not signed during release staging#1374
adoroszlai merged 1 commit intoapache:masterfrom
OneSizeFitsQuorum:jira2435

Conversation

@OneSizeFitsQuorum
Copy link
Contributor

Signed-off-by: OneSizeFitsQuorum <tanxinyu@apache.org>
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OneSizeFitsQuorum for the patch. I wonder if we should make ratis-bom inherit from Apache parent POM like ratis main POM does:

ratis/pom.xml

Lines 18 to 23 in 2c5412c

<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>35</version>
<relativePath /> <!-- resolve from repository -->
</parent>

Apache Pulsar's BOM does:

https://github.com/apache/pulsar/blob/c83cafc12eb1db4c3f17c4f0e47ebb3b8403fe56/pulsar-bom/pom.xml#L27-L32

@adoroszlai
Copy link
Contributor

Also, maybe it's a bit late at this point, but should we revert all BOM changes from release-3.2.2, deferring it to 3.3.0?

@adoroszlai adoroszlai requested a review from szetszwo March 12, 2026 16:43
@OneSizeFitsQuorum
Copy link
Contributor Author

Both solution is OK! And I believe this is the last issue for ratis-bom to release!

@adoroszlai
Copy link
Contributor

I prefer inheriting from Apache parent, because it requires less duplication and ensures consistent behavior for other inherited items, like plugin versions.

Current:

[INFO] --- clean:3.5.0:clean (default-clean) @ ratis-assembly ---
[INFO] --- clean:3.2.0:clean (default-clean) @ ratis-bom ---

@adoroszlai adoroszlai merged commit c9914ee into apache:master Mar 13, 2026
16 checks passed
adoroszlai pushed a commit that referenced this pull request Mar 13, 2026
@adoroszlai
Copy link
Contributor

Thanks @OneSizeFitsQuorum for the fix.

@OneSizeFitsQuorum OneSizeFitsQuorum deleted the jira2435 branch March 13, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants