RATIS-2437. make_rc.sh version check prevents releasing subsequent RCs#1376
Open
OneSizeFitsQuorum wants to merge 1 commit intoapache:masterfrom
Open
RATIS-2437. make_rc.sh version check prevents releasing subsequent RCs#1376OneSizeFitsQuorum wants to merge 1 commit intoapache:masterfrom
OneSizeFitsQuorum wants to merge 1 commit intoapache:masterfrom
Conversation
Signed-off-by: OneSizeFitsQuorum <tanxinyu@apache.org>
adoroszlai
approved these changes
Mar 13, 2026
adoroszlai
reviewed
Mar 13, 2026
| echo 'ratis-bom not updated by `mvn versions:set`' >&2 | ||
| exit 1 | ||
| fi | ||
| git commit --allow-empty -a -m "Change version for the version $RATISVERSION $RC" |
Contributor
There was a problem hiding this comment.
If version is already set, this empty commit is unnecessary. So I guess we can have two cases:
versions:setintroduces change => expect change ofratis-bomand do commit- otherwise => skip both check and commit
Contributor
Author
There was a problem hiding this comment.
Well, we need a commit to contains messages such as Change version for the version 3.2.2 rc2 even if nothing in pom has changed, that's why we need a --allow-empty flag.
You could see 45a30d8
Contributor
There was a problem hiding this comment.
I see the empty commit, but I think it's unnecessary.
Contributor
Author
There was a problem hiding this comment.
I guess it’s fine either way, but it’s definitely clearer with it. Otherwise, the latest commits might look like they're still on RC1, and we won't know if that's a mistake or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://issues.apache.org/jira/browse/RATIS-2437