RATIS-2438: Update membership-change documentation#1379
Open
snehasishroy wants to merge 1 commit intoapache:masterfrom
Open
RATIS-2438: Update membership-change documentation#1379snehasishroy wants to merge 1 commit intoapache:masterfrom
snehasishroy wants to merge 1 commit intoapache:masterfrom
Conversation
snehasishroy
changed the title
szetszwo
reviewed
Mar 16, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@snehasishroy , thanks a lot for catching the doc bug and fixing it! Please see the comments inlined.
| ```java | ||
| RaftServer N3 = RaftServer.newBuilder() | ||
| .setGroup(RaftGroup.emptygroup()) | ||
| .setGroup(RaftGroup.valueOf(groupId, List.of())) |
Contributor
There was a problem hiding this comment.
Please use standard Java API Collections.emptyList() and keep the indentation.
.setGroup(RaftGroup.valueOf(groupId, Collections.emptyList()))
| To add a new node (e.g., `N3`) to an existing group (e.g., `N0`, `N1`, `N2`), follow these steps: | ||
|
|
||
| 1. Start the new peer `N3` with **EMPTY** group. | ||
| 1. Start the new peer `N3` with the existing groupID but provide an empty list of peers. |
Contributor
There was a problem hiding this comment.
Let's use "the existing groupId and an empty list of peers."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix membership documentation
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2438