[ISSUE#173]Connect Exporter for Prometheus - #200
Conversation
|
|
||
|
|
||
| public class MetricsExportSinkTask extends SinkTask { | ||
| private List<MetricsExporter> metricsExporters; |
There was a problem hiding this comment.
Has the implementation of MetricsExporter been submitted yet?
There was a problem hiding this comment.
Sorry not yet :( . But I am trying my best to finish a exporter for Prometheus which gets the metrics from the log files, and some preliminary knowledge is got. And I hear the sftp source connector (my upstream task) is designing in the last weekly meeting. So I'm waiting for the implementation ConnectRecord in it in order to complete my parsing.
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
This PR modifies 6 file(s) with 198 lines of diff. No test changes detected — consider adding test coverage.
Automated review by github-manager-bot
| @@ -0,0 +1,41 @@ | |||
| package org.apache.rocket.connect.metrics.export.sink.connector; | |||
There was a problem hiding this comment.
No test changes detected alongside source modifications. Consider adding tests to cover the changes.
3 participants
ISSUE#173 What is the purpose of the change
Some simple interfaces designed for metric exposure.
Brief changelog
Design some interfaces to ensure exposure behavior of metrics provided by dynamic loading.Thus,we can export the metrics to anywhere we want, e.g. prometheus.