[bug] fix RepicatorCheckpointTask add acl ak/sk - #551
Conversation
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #551 — Fix ReplicatorCheckpointTask add ACL ak/sk
Type: Bug fix (1 file, +4/-0)
Assessment
Adds missing ACL access key/secret key configuration to the replicator checkpoint task. Minimal 4-line fix.
Verdict
✅ Correct fix for missing ACL credentials in replicator checkpoint flow.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Bug fix for ACL credential propagation in ReplicatorCheckpointTask. The PR adds the missing access key and secret key configuration for both source and destination endpoints, which are required when ACL is enabled on RocketMQ clusters.
Findings
- [Info] The fix is minimal and targeted — it only adds the four missing credential fields without changing other logic.
- [Info] Consider adding a unit test that verifies the credentials are properly propagated when ACL is enabled, to prevent regression.
Suggestions
The fix is correct and necessary for ACL-enabled deployments.
Automated review by github-manager-bot
RockteMQ-AI
left a comment
There was a problem hiding this comment.
LGTM — ReplicatorCheckpointTask.fillConnectorConfig() was missing ACL credential propagation for both source and destination endpoints. This would cause checkpoint replication to fail in ACL-enabled clusters. Fix correctly passes accessKey/secretKey for both src and dest.
Automated review by github-manager-bot
What is the purpose of the change
fix [ISSUE #550]
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.