[ISSUE #10256] Fix shared mutable batchAckIndexList causing toStoreBits update failure in PopBufferMergeService#10257
Open
LiyunZhang10 wants to merge 3 commits into
Conversation
…toreBits update failure in PopBufferMergeService When enablePopBatchAck and appendAckAsync are both enabled, scan() passes a class-level shared batchAckIndexList to the async putBatchAckToStore(), then immediately clears the list in the finally block. The async callback captures the same (now-empty) list reference, causing toStoreBits to never be updated. This prevents checkpoint wrappers from being removed from the unbounded commitOffsets queue, leading to memory leak and potential OOM. Fix: pass a defensive copy new ArrayList<>(indexList) so the async callback captures an independent snapshot of the index data. Made-with: Cursor
LiyunZhang10
force-pushed
the
fix-shared-batchAckIndexList-in-PopBufferMergeService
branch
from
7bee793 to
c2884e5
Compare
RongtongJin
previously approved these changes
May 30, 2026
Contributor
|
Could you please merge the latest |
…AckIndexList-in-PopBufferMergeService
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10257 +/- ##
=============================================
- Coverage 48.03% 47.95% -0.08%
+ Complexity 13284 13252 -32
=============================================
Files 1376 1376
Lines 100536 100536
Branches 12983 12983
=============================================
- Hits 48292 48214 -78
- Misses 46326 46356 +30
- Partials 5918 5966 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
When
enablePopBatchAckandappendAckAsyncare both enabled,PopBufferMergeService.scan()passes a class-level sharedbatchAckIndexListto the asyncputBatchAckToStore(), then immediately clears the list in thefinallyblock. The async callback captures the same (now-empty) list reference, causingtoStoreBitsto never be updated. This prevents checkpoint wrappers from being removed from the unboundedcommitOffsetsqueue, leading to memory leak and potential OOM.Changes
Pass a defensive copy
new ArrayList<>(indexList)toputBatchAckToStore()so the async callback captures an independent snapshotAdded unit test
testBatchAckAsyncShouldUpdateToStoreBitsAfterFixto verifytoStoreBitsis correctly updated after async callback completes