[ISSUE #10410] Fix RocksDBOptionsFactoryTest compile failure#10411
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10411 +/- ##
=============================================
- Coverage 48.03% 47.93% -0.10%
+ Complexity 13284 13252 -32
=============================================
Files 1376 1376
Lines 100536 100558 +22
Branches 12983 12985 +2
=============================================
- Hits 48292 48203 -89
- Misses 46326 46411 +85
- Partials 5918 5944 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lizhimins
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #10410
Fixes #10412
Fixes #10413
Brief Description
RocksDBOptionsFactoryTestreferenced a non-existentConsumeQueueCompactionFilterFactoryand called a non-existent overload ofRocksDBOptionsFactory.createCQCFOptions, causingrocketmq-storetest compilation to fail. This PR updates the test to call the currentcreateCQCFOptions(MessageStore)API directly.It also stabilizes
BrokerOuterAPITest.testPullMessageFromSpecificBrokerAsync_brokerReturn_pullStatusCodeby mocking theinvokeAsynccallback directly for each broker response code. The previous test reused a completed NettyDefaultChannelPromiseand repeatedly re-stubbed the same spy in a loop, making it sensitive to listener scheduling on macOS CI.Finally, it stabilizes
DefaultLitePullConsumerTest.testSubscribe_BroadcastPollMessageSuccessby stubbing the injectedMQClientAPIImplmock directly and avoiding spy calls while preparing Mockito stubs.How Did You Test This Change?
git diff --checkmvn -pl store -am -DskipTests test-compilemvn -pl common,remoting,store -Dtest=org.apache.rocketmq.store.rocksdb.RocksDBOptionsFactoryTest -Dsurefire.failIfNoSpecifiedTests=false testmvn -pl broker -am -DskipTests test-compilemvn -pl broker -am -Djacoco.skip=true -DargLine='--add-exports=java.xml/jdk.xml.internal=ALL-UNNAMED' -Dtest=org.apache.rocketmq.broker.BrokerOuterAPITest#testPullMessageFromSpecificBrokerAsync_brokerReturn_pullStatusCode -Dsurefire.failIfNoSpecifiedTests=false testmvn -pl client -am -Djacoco.skip=true -Dtest=org.apache.rocketmq.client.consumer.DefaultLitePullConsumerTest#testSubscribe_BroadcastPollMessageSuccess -Dsurefire.failIfNoSpecifiedTests=false testmvn -pl client -am -Djacoco.skip=true -Dtest=org.apache.rocketmq.client.consumer.DefaultLitePullConsumerTest -Dsurefire.failIfNoSpecifiedTests=false test