Skip to content

[ISSUE #10808] Tolerate proxy delay level whitespace - #10809

Open
Aias00 wants to merge 1 commit into
apache:developfrom
Aias00:fix/proxy-delay-level-whitespace-10808
Open

[ISSUE #10808] Tolerate proxy delay level whitespace#10809
Aias00 wants to merge 1 commit into
apache:developfrom
Aias00:fix/proxy-delay-level-whitespace-10808

Conversation

@Aias00

@Aias00 Aias00 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

What

  • Parse Proxy messageDelayLevel with trimmed \s+ tokens instead of splitting only on a single space.
  • Fall back to the default delay level config when the value is blank, so useDelayLevel does not later read an empty table.
  • Add ProxyConfigTest coverage for repeated whitespace and blank config values.

Why

messageDelayLevel is a config-file value. Repeated spaces, tabs, newlines, or blank input should not leave Proxy delay-level parsing partially populated or empty.

Validation

  • JAVA_HOME=$(/usr/libexec/java_home -v 1.8) mvn -pl proxy -DskipITs -DskipCheckStyle -Dtest=ProxyConfigTest test
  • git diff --check

Closes #10808

Copilot AI review requested due to automatic review settings August 4, 2026 00:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov-commenter

codecov-commenter commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.23%. Comparing base (eddb235) to head (6120da7).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10809      +/-   ##
=============================================
- Coverage      48.34%   48.23%   -0.12%     
+ Complexity     13527    13493      -34     
=============================================
  Files           1380     1380              
  Lines         101104   101107       +3     
  Branches       13107    13108       +1     
=============================================
- Hits           48882    48769     -113     
- Misses         46267    46359      +92     
- Partials        5955     5979      +24     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Adds trim() to delay-level parsing in the proxy to tolerate leading/trailing whitespace in configuration values. Simple defensive fix with good test coverage for whitespace, empty, and invalid inputs.

LGTM.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Proxy delay level parsing should tolerate extra whitespace

4 participants