Repository navigation
Conversation
Signed-off-by: zhang hongyuan <100520587+Metastarx@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #11451 +/- ##
=============================================
+ Coverage 49.76% 49.98% +0.21%
- Complexity 14377 14527 +150
=============================================
Files 1390 1393 +3
Lines 103262 103435 +173
Branches 13504 13522 +18
=============================================
+ Hits 51392 51698 +306
+ Misses 45681 45529 -152
- Partials 6189 6208 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
reviewed
Oct 18, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Suggestions
- Remove
broker/null/config/delayOffset.json— likely an accidental commit. - Add a server-side cap on
maxCountin the processor (e.g.,Math.min(maxCount, 10000)). - Wrap
Integer.parseIntin the SubCommand with a user-friendly error message.
Overall
The implementation is clean, follows existing patterns for lite topic admin commands, and has good test coverage. The protocol design (reusing LiteTopicRequestHeader, adding hasMore for pagination) is sound. Addressing the accidental file and the two warnings above would make this ready to merge.
Automated review by github-manager-bot
Signed-off-by: zhang hongyuan <100520587+Metastarx@users.noreply.github.com>
Contributor
Author
|
Addressed in bb28e1b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
RocketMQ currently exposes an aggregate lite topic count plus single-topic and single-client lookups, but there is no broker-side way to enumerate the dynamically created lite topics under a parent topic. This change adds a GET_LITE_TOPIC_LIST request with a required parent topic, an optional name prefix, and a bounded maxCount, and the broker returns each lite topic's offsets, last update time, subscriber count, and sharding ownership together with a hasMore truncation flag. The new client, admin, and DefaultMQAdminExt methods are wired through a getLiteTopicList mqadmin command (also available as listLiteTopic) that prints one table row per broker, and the LMQ guide documents the command and sample output.
How Did You Test This Change?
mvn test -pl broker,client,remoting,tools- passed (Tests run: 172, Failures: 0, Errors: 0, Skipped: 5)