[ISSUE #9959] Correct thread name prefix for file recycling executor in tiered store #9960
+72
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cutor in tiered store
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9960 +/- ##
=============================================
- Coverage 48.80% 48.73% -0.08%
+ Complexity 12775 12756 -19
=============================================
Files 1327 1327
Lines 96441 96441
Branches 12440 12440
=============================================
- Hits 47065 46997 -68
- Misses 43631 43690 +59
- Partials 5745 5754 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuz10
previously approved these changes
Jan 6, 2026
Member
|
Good catch. Can you merge the unit tests into one? |
lizhimins
reviewed
Jan 7, 2026
|
|
||
| @Test | ||
| public void testFileRecyclingExecutorThreadNamePrefix() throws Exception { | ||
| assertThreadNamePrefix(executor.fileRecyclingExecutor, "FileRecyclingExecutor_", |
Member
There was a problem hiding this comment.
Can you merge the unit tests into one?
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9959
Brief Description
Thread use the correct name prefix.
How Did You Test This Change?
Unit test