fix: skip request body for GET and HEAD requests#6350
Open
zongmingzhi wants to merge 2 commits into
Open
Conversation
GET and HEAD requests should not forward a request body through the HTTP client plugins. Sending a body can cause Reactor Netty or WebClient to emit unexpected transfer encoding headers, which may break compatibility with upstream servers. Add shared request-body eligibility logic in AbstractHttpClientPlugin and reuse it from both NettyHttpClientPlugin and WebClientPlugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents the HTTP client plugins from forwarding request bodies for GET and HEAD requests.
Sending a body for GET or HEAD may cause Reactor Netty or WebClient to emit unexpected transfer encoding headers, which can break compatibility with some upstream servers.
Changes
AbstractHttpClientPlugin.NettyHttpClientPlugin.WebClientPlugin.Tests
./mvnw -pl shenyu-plugin/shenyu-plugin-httpclient -am -DskipTests validate./mvnw -pl shenyu-plugin/shenyu-plugin-httpclient -am testChecklist
./mvnw -pl shenyu-plugin/shenyu-plugin-httpclient -am test.